Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle password reset dynamic url redirection in prospectus #47

Conversation

syedsajjadkazmii
Copy link

@syedsajjadkazmii syedsajjadkazmii commented Jun 25, 2024

The password reset dynamic URL first shows the 404 page in edx.org before redirecting the actual component.

We are applying this fix to avoid seeing 404 page.


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1966/handle-password-reset-dynamic-url-prospectus branch 2 times, most recently from 0653701 to 9e02ef4 Compare June 25, 2024 15:47
@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1966/handle-password-reset-dynamic-url-prospectus branch from 9e02ef4 to bddefe0 Compare June 25, 2024 15:48
Copy link
Member

@bseverino bseverino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot

@syedsajjadkazmii syedsajjadkazmii merged commit cf7f59f into master Jun 25, 2024
4 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/VAN-1966/handle-password-reset-dynamic-url-prospectus branch June 25, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants