Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing parens #16

Merged
merged 1 commit into from
May 22, 2024
Merged

fix: add missing parens #16

merged 1 commit into from
May 22, 2024

Conversation

christopappas
Copy link

Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

robrap
robrap approved these changes May 22, 2024
View reviewed changes
Copy link

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the earlier version was ok, this seems ok.

@christopappas christopappas merged commit ea52958 into master May 22, 2024
4 checks passed
@christopappas christopappas deleted the cpappas/REV-4051-2 branch May 22, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrap robrap robrap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christopappas @robrap