Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt #6 at removing paver #143

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Attempt #6 at removing paver #143

merged 2 commits into from
Dec 19, 2024

Conversation

timmc-edx
Copy link
Member

This reverts the previous revert ce176c4 from #140 so I can add a fix on top of it. See second commit.


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

This reverts the revert ce176c4 from #140 so I can add a fix on top of
it.
Copy link

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but can you wait until regular business hours to merge and coordinate with anyone or any team who may have run into issues during attempts 1-5? :)

@timmc-edx
Copy link
Member Author

Yep! Just queuing it up for tomorrow. :-)

@dianakhuang dianakhuang merged commit 6981305 into master Dec 19, 2024
3 checks passed
@dianakhuang dianakhuang deleted the timmc/paver6 branch December 19, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants