Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix django.cache service tags for Inferred Services config #131

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

timmc-edx
Copy link
Member

This is intended as a temporary workaround until Datadog can put in a proper fix.


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

This is intended as a temporary workaround until Datadog can put in a
proper fix.
Copy link

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to an issue for cleaning this up. It might even replace the help link, which could be in the issue, and won't be accessible by most people. Thanks.

@timmc-edx
Copy link
Member Author

Ah yeah, I think I meant to link to the Inferred Services issue instead -- I'm going to be mentioning this as a thing to clean up in the A/C of that issue. I'll link there instead in any case.

@timmc-edx timmc-edx merged commit edf846c into master Dec 12, 2024
3 checks passed
@timmc-edx timmc-edx deleted the timmc/infsrv-cache branch December 12, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants