Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: turn on DD profiling timeline. #105

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

dianakhuang
Copy link
Member


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

@@ -30,6 +30,7 @@ export DD_DJANGO_INSTRUMENT_MIDDLEWARE=false
{% if EDXAPP_DATADOG_PROFILING_ENABLE %}
export DD_PROFILING_ENABLED=true
export DD_PROFILING_STACK_V2_ENABLED=true
export DD_PROFILING_TIMELINE_ENABLED=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to add a comment indicating that this is temporary and in pursuit of debugging, rather than a feature we specifically wanted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I think it's possible it will be useful in the future if it does help with debugging.

@dianakhuang dianakhuang merged commit 707a072 into master Nov 15, 2024
3 checks passed
@dianakhuang dianakhuang deleted the diana/profiling-timeline branch November 15, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants