fix: Apply suggestions from code review

Co-authored-by: Tim McCormack <[email protected]>
edx · May 22, 2024 · 58aa8c5 · 58aa8c5
1 parent 5bde1ec
commit 58aa8c5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/playbooks/roles/edx_django_service/tasks/main.yml b/playbooks/roles/edx_django_service/tasks/main.yml
@@ -213,9 +213,7 @@
     - install:app-requirements
 
 - name: "Install Datadog APM requirements"
-  when: >
-    COMMON_ENABLE_DATADOG and
-    (COMMON_ENABLE_DATADOG_APP or edx_django_service_datadog_enable)
+  when: edx_django_service_datadog_enable
   pip:
     name:
       - ddtrace

diff --git a/playbooks/roles/edx_django_service/templates/edx/app/app/app.sh.j2 b/playbooks/roles/edx_django_service/templates/edx/app/app/app.sh.j2
@@ -20,7 +20,7 @@ fi
 export NEW_RELIC_LICENSE_KEY="{{ NEWRELIC_LICENSE_KEY }}"
 {% endif -%}
 
-{% if COMMON_ENABLE_DATADOG and (COMMON_ENABLE_DATADOG_APP or edx_django_service_datadog_enable) %}
+{% if edx_django_service_datadog_enable %}
 {% set executable = edx_django_service_venv_bin + '/ddtrace-run ' + executable %}
 export DD_TAGS="service:{{ edx_django_datadog_service }}"
 export DD_DJANGO_USE_HANDLER_RESOURCE_FORMAT=true