Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the PICASSO_ prefix condition to find packages #4

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

MaferMazu
Copy link
Collaborator

Description

This PR comes from this feedback: https://3.basecamp.com/3966315/buckets/12732851/messages/7749977969#__recording_7753938708

And also, in our Readme we had that prefix condition: https://github.com/eduNEXT/tutor-contrib-picasso?tab=readme-ov-file#enable-private-packages

Also:

It is very strongly recommended to prefix unique and default settings with the plugin name, in all-caps, such that different plugins with the same configuration do not conflict with one another.

From Tutor documentation: https://docs.tutor.edly.io/tutorials/plugin.html#modifying-configuration

@MaferMazu MaferMazu force-pushed the mfmz/improve-prefix-checker branch from b77ce96 to f326db5 Compare August 28, 2024 20:46
@MaferMazu MaferMazu merged commit c1e0465 into main Aug 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants