-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: add redwood compatibility #68
Conversation
When 'enable-themes' was executed before, a new execution failed overriding the existing folder
3bcb615
to
1924007
Compare
tutordistro/distro/extra_commands/infrastructure/tutor_commands.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bra-i-am, thank you! I'll be testing this to ensure everything works smoothly, but in the meantime, I'm leaving some suggestions here.
tutordistro/distro/extra_commands/infrastructure/tutor_commands.py
Outdated
Show resolved
Hide resolved
Thank you @bra-i-am for this PR. 🔵 Changes:
Open a bash inside the container tutor dev exec lms bash Then compile the themes npm run compile-sass -- --theme-dir [THEME_DIR] --theme [THEME_NAME] 🔸I try with 🔵 As a suggestion, we can improve the testing instructions, for example
🔸 The MFE reference could be unnecessary. 🔵 No blocker issues for this PR, but some improvements that I noticed with this testing for later (maybe):
|
* refactor: improve & update method of compiling themes * refactor: enhance extra command logs * docs: Clarify & complement changelog entry
30aecc3
to
e070250
Compare
Description
This PR aims to give Distro support to Redwood's release. Additionally, taking advantage of this maintenance effort, it was solved a found bug with the command 'enable themes' when the command was executed before, if was executed again it stayed frozen because if it was not sent a 'yes', the command could not override the previous created folder.
Testing instructions
pip install git+https://github.com/eduNEXT/tutor-contrib-edunext-distro@bc/add-redwood-support
and enable ittutor plugins enable distro
config.yml
and runtutor config save
config.yml
are executed properly.; in this case will be run 2 Distro commands:tutor distro enable-themes
: you should find a folder ednx-saas-themes atenv/build/openedx/themes
tutor distro enable-private-packages
you should find a folder eox-manage atenv/build/openedx/requirements
ADDITIONAL CASES
DISTRO_EOX_THEMING_DPKG
is missing thepath
key & value) you should watch an errorDISTRO_EOX_THEMING_DPKG
has the value ofrepo
misspelled) you should watch an errorbragi
andcss-runtime
) if I set a default theme (i.g. DISTRO_DEFAULT_SITE_THEME = css-runtime) in theconfig.yml
then I could access it in the LMS/CMS configuration.At last, create an image with the new settings
tutor images build openedx
, and once this is finished, init the environmenttutor local do init
and start the environment in local modetutor local start
. To confirm everything goes as expected, besides creating the image without errors, it is important to confirm (1) that the versions of the EOXs that are installed correspond with the ones defined in theconfig.yml
, accessing the containertutor local exec lms
and watching the installed dependenciespip list
and (2) that we can seebragi
as the default theme.Additional information
JIRA ISSUE DS-1007