Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: validate repos with git commands & improve readability #64

Merged
merged 2 commits into from
May 28, 2024
Merged

refactor: validate repos with git commands & improve readability #64

merged 2 commits into from
May 28, 2024

Conversation

bra-i-am
Copy link
Contributor

@bra-i-am bra-i-am commented May 24, 2024 •
edited
Loading

Description

This PR aims to fix the issue #63 where the repository validator command failed incorrectly.

How to test

  • Have a Quince environment and install this branch: pip install git+https://github.com/eduNEXT/tutor-contrib-edunext-distro@bc/fix-repo-validations
  • Add in the config.yml
OPENEDX_EXTRA_PIP_REQUIREMENTS:
- git+https://github.com/eduNEXT/no-existing-repo
- git+https://github.com/eduNEXT/edx-ora2@no-existing-branch#egg=ora2==5.5.7
  • Run the command of validation: tutor distro repository-validator

Note: Should not show an error if the thing after @ is a valid branch or a valid tag.

Evidence

image

JIRA ISSUE DS-939

@bra-i-am bra-i-am linked an issue May 24, 2024 that may be closed by this pull request
[BUG] Validation repository command fails when should not #63
Closed
@bra-i-am bra-i-am force-pushed the bc/fix-repo-validations branch from b9df829 to ba7e135 Compare May 24, 2024 16:40
@bra-i-am bra-i-am force-pushed the bc/fix-repo-validations branch from ba7e135 to 38eeaa4 Compare May 24, 2024 16:47
@bra-i-am bra-i-am requested a review from a team May 24, 2024 16:51
@luisfelipec95
Copy link
Contributor

Thanks @bra-i-am , I followed these steps: Install Quince (17.0.4) with distro and execute the following commands:
tutor plugins disable indigo
pip install tutor-mfe
tutor plugins enable distro
tutor config save
tutor distro repository-validator
image

@bra-i-am bra-i-am force-pushed the bc/fix-repo-validations branch from 38eeaa4 to e85ae9f Compare May 27, 2024 12:13
@bra-i-am bra-i-am force-pushed the bc/fix-repo-validations branch from e85ae9f to e67849e Compare May 27, 2024 13:05
@github-actions github-actions bot added size/m and removed size/s labels May 27, 2024
@bra-i-am
Copy link
Contributor Author

hey @luisfelipec95, thanks a lot for your review. The error was already solved, please re-check the behavior. I'll be waiting if any other fix is required.

luisfelipec95
luisfelipec95 approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@luisfelipec95 luisfelipec95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Asespinel
Asespinel approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@Asespinel Asespinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as expected
Screenshot from 2024-05-27 17-02-47

@bra-i-am bra-i-am merged commit 0f91648 into master May 28, 2024
4 checks passed
@bra-i-am bra-i-am deleted the bc/fix-repo-validations branch May 28, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Asespinel Asespinel Asespinel approved these changes

@luisfelipec95 luisfelipec95 luisfelipec95 approved these changes

Assignees

@MaferMazu MaferMazu

@Asespinel Asespinel

Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Validation repository command fails when should not
4 participants
@bra-i-am @luisfelipec95 @Asespinel @MaferMazu