feat: create a new command to run extra tutor commands #59
Conversation
bra-i-am
changed the title
tutordistro/distro/extra_commands/infrastructure/tutor_commands.py
Outdated
Show resolved
Hide resolved
|
I tested it and works pretty well, in the middle of this process I found an edge case, running 2 or more commands in one line, such as I love being able to use it but it also allows me to run different commands like: |
tutordistro/distro/extra_commands/infrastructure/tutor_commands.py
Outdated
Show resolved
Hide resolved
bra-i-am
force-pushed
the
bc/create_run_extra_commands
branch
from
480bb40 to
05bc60a
Compare
* refactor: solve some linter issues and
* refactor: execute the commands validation before any command is executed * test: fix tests to run with the latest changes
bra-i-am
force-pushed
the
bc/create_run_extra_commands
branch
from
a943433 to
7cddc34
Compare
bra-i-am
force-pushed
the
bc/create_run_extra_commands
branch
4 times, most recently
from
275959c to
2f32953
Compare
* fix: solve tests failing because using a class method directly in tests
bra-i-am
force-pushed
the
bc/create_run_extra_commands
branch
from
2f32953 to
fcd736d
Compare
There was a problem hiding this comment.
I'm sorry for not getting back to you sooner.
Thanks a lot for this PR; kudos for the test and the structure you built.
The primary function works as expected, but I get an error when I try to run the command run-extra-commands without defining DISTRO_EXTRA_COMMANDS. That behavior will generate errors in Picasso because we will run extra commands as part of the pipeline, and if someone doesn't need extra commands and doesn't have the variable, this breaks.
Another feedback is we probably want to add documentation about this new feature in the Usage section in the readme, to know how to use this new command.
But that's it; the rest looks super good. Thanks again.
* fix: no sent CommandError when DISTRO_EXTRA_COMMANDS is no sent in the config.yml
Description
This PR creates a new command to run extra commands added into a property
DISTRO_EXTRA_COMMANDSin theconfig.ymlfileTesting instructions
Access to the new pipeline of Picasso, "Build with Parameter" and click in "Build"; here you'll be testing the commands added in the config.yml from palm/dedalo strain. Feel free of modifying the commands as you like.
Additional information
JIRA ISSUE DS-826