Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add support for palm #55

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

Ever3tt
Copy link
Contributor

@Ever3tt Ever3tt commented Nov 30, 2023

Description

This PR wants to add palm compatibility to the plugin

Questions

Do we need to change something else?

BREAKING CHANGE: add support for palm
@andrey-canon andrey-canon requested review from MaferMazu and a team December 6, 2023 14:54
Copy link
Contributor

@dcoa dcoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

@MaferMazu MaferMazu changed the title BREAKING CHANGE: add support for palm feat!: add support for palm Dec 12, 2023
@MaferMazu
Copy link
Contributor

@Ever3tt, thanks for this contribution 🙌
It looks good to me, but I need to ask you to revert or avoid changing the CHANGELOG.md setup.cfg tutordistro/__about__.py because those files change automatically when we merge your PR.

Reference:
https://github.com/eduNEXT/tutor-contrib-edunext-distro/blob/master/.github/workflows/bump_version.yml#L29

@Ever3tt
Copy link
Contributor Author

Ever3tt commented Dec 13, 2023

@MaferMazu thank you for giving me the oportunity.

I reverted the versions of the files that you mentioned :D

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Ever3tt

@MaferMazu MaferMazu merged commit 6f1f12a into eduNEXT:master Dec 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants