feat: handle absolute URIs in PUBLIC_PATH (openedx#568)

Webpack allows `publicPath` to be an absolute URI (https://webpack.js.org/configuration/output/#outputpublicpath), in order to support deployments to a CDN.  However, the browser history module expects a relative path for `basename` but uses the same environment variable (`PUBLIC_PATH`) to configure it.  Since the path is always expected to be be suffixed to the absolute URI, we avoid introducing another configuration variable (thus maintaining full backwards compatibility) by extracting it at initialization time.

src/utils.js

@@ -138,13 +138,9 @@ export function convertKeyNames(object, nameMap) {
  * @returns {Object}
  */
 export function parseURL(url) {
-  if (typeof document !== 'undefined') {
-    const parser = document.createElement('a');
-    parser.href = url;
-    return parser;
-  }
-
-  return {};
+  const parser = document.createElement('a');
+  parser.href = url;
+  return parser;
 }
 
 /**
@@ -155,7 +151,7 @@ export function parseURL(url) {
  * @returns {string}
  */
 export function getPath(url) {
-  return typeof document !== 'undefined' ? parseURL(url)?.pathname : '';
+  return parseURL(url).pathname;
 }
 
 /**

src/utils.test.js

@@ -119,16 +119,6 @@ describe('getQueryParameters', () => {
 describe('ParseURL', () => {
   const testURL = 'http://example.com:3000/pathname/?search=test#hash';
   const parsedURL = parseURL(testURL);
-  let originalDocument;
-
-  beforeEach(() => {
-    originalDocument = global.document;
-  });
-
-  afterEach(() => {
-    global.document = originalDocument;
-  });
-
   it('String URL is correctly parsed', () => {
     expect(parsedURL.toString()).toEqual(testURL);
     expect(parsedURL.href).toEqual(testURL);
@@ -162,12 +152,6 @@ describe('ParseURL', () => {
   it('should return host from URL', () => {
     expect(parsedURL.host).toEqual('example.com:3000');
   });
-
-  it('should return empty object in case of document being undefined', () => {
-    delete global.document;
-
-    expect(parseURL(testURL)).toEqual({});
-  });
 });
 
 describe('getPath', () => {