fix: templates loading reset #234
Conversation
This fix the order ready method of eox_nelp works. Mainly this avoid that if eox_nelp is intalled before eox_theming. eox_theming should not reset look_ups in it ready method. https://github.com/eduNEXT/eox-theming/blob/v8.1.0/eox_theming/apps.py#L58 So with this change eox_nelp exteding template in the ready method would work. https://github.com/eduNEXT/eox-nelp/blob/8c8306e59e94bc0209c49d044dc5d5c12874be98/eox_nelp/init_pipeline.py#L60
Could you try again ? I tried that solution on my local machine and that worked |
| @@ -82,3 +82,7 @@ def plugin_settings(settings): | |||
| except AttributeError: | |||
| # We must find a way to register this error | |||
| pass | |||
| # Ensure EOX_NELP is the last plugin installed app for ready run. | |||
| if EOX_NELP_MODEL_APP in settings.INSTALLED_APPS and settings.INSTALLED_APPS[-1] != EOX_NELP_MODEL_APP: | |||
There was a problem hiding this comment.
could you move this logic to the settings file(nelc-dev-kit/plugins/extra_env_patches.py and manifest-sagar/plugins) ?? I make this suggestion because you're fixing the app position and if we need to change that later, this implementation makes harder to modify that order
There was a problem hiding this comment.
could you move this logic to the settings file(nelc-dev-kit/plugins/extra_env_patches.py and manifest-sagar/plugins) ?? I make this suggestion because you're fixing the app position and if we need to change that later, this implementation makes harder to modify that order
Yes I could, also in the plugin you could reorder. As you see custom_reg_form is appended using the env patches. Anyway, if you think is better the fix there I could do it.
@andrey-canon I am trying it in this way. But is not working, is something I am doing wrong? Maybe only work in tenant_config? |
I tested this with tenant config, but I think this should work with general settings if the tenant has the EDNX_USE_SIGNAL setting |
|
Heeding the recommendations of the PR, this fix would be handled by env patches settings. |
Description
This fix the order ready method of eox_nelp works. Mainly this avoid that if eox_nelp is intalled before eox_theming. eox_theming should not reset look_ups in it ready method. https://github.com/eduNEXT/eox-theming/blob/v8.1.0/eox_theming/apps.py#L58
So with this change eox_nelp exteding template in the ready method would work.
eox-nelp/eox_nelp/init_pipeline.py
Line 60 in 8c8306e
Testing instructions
Go to stats view in redwood dev kit or in an image where eox_nelp was installed before eox_theming.
http://local.overhang.io:8000/eox-nelp/stats/tenant/Before
After
Additional information
I tried EDNX_INSTALLED_APPS spec but doesn't work.
Checklist for Merge