Jlc/NIDpipelines #232
Merged
Jlc/NIDpipelines #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As username was changed as national_id, now the national_id needs to be loaded using other fields. So now user is looked up using: - safer_associate_user_by_national_id: extrainfo__national_id - safer_associate_user_by_social_auth_record: social_auth__uid__endswith Also there is other pipe that was separated to manage staff and superusers. - disallow_staff_superuser_users
andrey-canon
approved these changes
Nov 8, 2024
|
|
||
| class SaferAssociaciateUserBySocialAuthRecordTestCase(SaferAssociateUserUsingUid, TestCase): | ||
| """Test case for `safer_associate_user_by_social_auth_record`""" | ||
| uid_pipe = staticmethod(safer_associate_user_by_social_auth_record) |
There was a problem hiding this comment.
just asking why this instead of uid_pipe = safer_associate_user_by_social_auth_record ?
There was a problem hiding this comment.
Because as is defined inside a class. When the function is called(self.uid_pipe()) the first argument is filled with self. So the order function fails...
|
|
||
| self.backend.get_idp.return_value.get_user_permanent_id.return_value = test_uid | ||
| self.backend.strategy.storage.user.get_user.return_value = past_user | ||
|
|
||
| pipe_output = safer_associate_username_by_uid(self.request, self.backend, self.details, self.response) | ||
| pipe_output = safer_associate_user_by_national_id(self.request, self.backend, self.details, self.response) |
There was a problem hiding this comment.
Suggested change
| pipe_output = safer_associate_user_by_national_id(self.request, self.backend, self.details, self.response) | |
| pipe_output = self.uid_pipe(self.request, self.backend, self.details, self.response) |
??? I Think it's the same but this suggestion keeps the style of other tests
| @@ -94,7 +136,49 @@ def test_user_associate_username_with_uid(self): | |||
| self.backend.get_idp.return_value.get_user_permanent_id.return_value = test_uid | |||
| self.backend.strategy.storage.user.get_user.return_value = past_user | |||
|
|
|||
| pipe_output = safer_associate_username_by_uid(self.request, self.backend, self.details, self.response) | |||
| pipe_output = safer_associate_user_by_social_auth_record( | |||
There was a problem hiding this comment.
same comment as above
johanseto
force-pushed
the
jlc/national_id_pipelines
branch
from
cf82485 to
8b11e10
Compare
johanseto
force-pushed
the
jlc/national_id_pipelines
branch
from
8b11e10 to
c69533b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As username was changed as national_id, now the national_id needs to be
loaded using other fields.
eg
uid=1999444333So now user is looked up using:
Also there is other pipe that was separated to manage staff and superusers.
Testing instructions
We need to change the pipelines functions in this way.
Before
After
Check if saml association are working =)
Additional information
Jira story
Checklist for Merge