Jlc/palm mig/patch generate passwords #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
force-pushed
the
jlc/palm-mig/patch-generate-passwords
branch
from
b700e1b to
3b56f1b
Compare
andrey-canon
approved these changes
Feb 29, 2024
johanseto
force-pushed
the
jlc/palm-mig/patch-generate-passwords
branch
from
65f43eb to
c5e16ed
Compare
feat: first version of monkey patching feat: add django-password-validators==1.7.3 This is the latest (now), feb5-2024 feat: add edx-django-utils pck feat: add generate password to init pipeline chore: add natural docstring style: pylint and isort feat: add logging msg of generation password feat: add edx-django-utils style: pass flake8 long line error chore: remove duplicated req
andrey-canon
force-pushed
the
jlc/palm-mig/patch-generate-passwords
branch
from
c5e16ed to
f925718
Compare
OmarIthawi
reviewed
Jul 22, 2024
Comment on lines
+93
to
+96
| from edx_django_utils import user | ||
|
|
||
| from eox_nelp.user_authn.utils import generate_password | ||
| user.generate_password = generate_password |
There was a problem hiding this comment.
Thanks @johanseto for the fix today.
I believe we should patch the generate password locally inside the importing modules:
from lms.djangoapps.support.views import manage_user
manage_user.generate_password = generate_password
Otherwise the imports won't be updated in manage_user due to the patch being too late in the import order.
What do you think?
There was a problem hiding this comment.
Forking edx_django_utils is also an option.
There was a problem hiding this comment.
Thanks @OmarIthawi the patching locally is managed this PR.
https://github.com/eduNEXT/eox-nelp/pull/208/files
Is doing what you recommend using eox-tenant and seems working. Let us check out the behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a monkey patch to generate_password.
This was a PR of edx-platform but now this is included in eox-nelp.
As the feature of the PR needs django-password-validators this PR add to eox-nelp the possibility to install it.
Also edx-django-utils is included in requirements, but is a normal package of edx-platform.
I added a logger to know that the password is generated via eox-nelp.
Testing instructions
install this package with this branch
Configure auth password validators in settings with custom rules, you could use this as eg.
Check into
/registerin the password field that you custom rules are loaded.Use a saml integration in your local env and complete a register flow, then check that the process is complete without problem. Check into logs that eox-nelp geneate the password.
After
Screencast.from.05-02-24.15.44.04.webm
Additional information
PRs related
nelc/edx-platform#4
eduNEXT/edunext-platform#676