Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add TestPathRedirectionMiddleware integration tests AP-1547 #298

Merged
merged 10 commits into from
Nov 18, 2024
Merged

test: add TestPathRedirectionMiddleware integration tests AP-1547 #298

merged 10 commits into from
Nov 18, 2024

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Oct 28, 2024 •
edited by jira bot
Loading

Description

This PR adds integration tests for the TestPathRedirectionMiddleware middleware. These tests are executed in the job of Tutor Integration Tests

Testing instructions

Check the jobs of Tutor Integration Tests in the PR.

Jira Issue

@BryanttV BryanttV force-pushed the bav/middleware-integration-tests branch 2 times, most recently from 14220fc to 10dd64f Compare November 1, 2024 16:08
@BryanttV BryanttV mentioned this pull request Nov 1, 2024
Merged
@BryanttV BryanttV force-pushed the bav/middleware-integration-tests branch 9 times, most recently from 86c3ec7 to 5816b47 Compare November 7, 2024 20:14
@BryanttV BryanttV marked this pull request as ready for review November 7, 2024 20:14
@BryanttV BryanttV requested a review from a team as a code owner November 7, 2024 20:14
@BryanttV BryanttV force-pushed the bav/middleware-integration-tests branch 2 times, most recently from 1564138 to 7724856 Compare November 13, 2024 04:11
mariajgrimaldi
mariajgrimaldi reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this PR is ready for review, cause I think an issue was still being addressed. Please, let me know to go through it again :)

eox_core/tests/integration/test_middleware.py Show resolved Hide resolved
eox_core/tests/integration/test_middleware.py Outdated Show resolved Hide resolved
@BryanttV BryanttV requested review from mariajgrimaldi and a team November 13, 2024 17:44
@BryanttV BryanttV force-pushed the bav/middleware-integration-tests branch from cf996d8 to 80ed570 Compare November 13, 2024 17:44
mariajgrimaldi
mariajgrimaldi previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few non-blocking comments for you to address. Other than that, it looks good to me!

eox_core/tests/integration/utils.py Outdated Show resolved Hide resolved
eox_core/tests/integration/utils.py Show resolved Hide resolved
eox_core/tests/integration/utils.py Outdated Show resolved Hide resolved
@mariajgrimaldi
Copy link
Contributor

@BryanttV, thanks for the context!

@BryanttV BryanttV force-pushed the bav/middleware-integration-tests branch from 567f831 to 2979348 Compare November 14, 2024 19:46
@BryanttV BryanttV requested a review from a team November 14, 2024 22:07
@BryanttV BryanttV force-pushed the bav/middleware-integration-tests branch from 6f5e30b to 731cfd8 Compare November 15, 2024 14:21
mariajgrimaldi
mariajgrimaldi previously approved these changes Nov 18, 2024
View reviewed changes
@BryanttV BryanttV force-pushed the bav/middleware-integration-tests branch from 731cfd8 to 4e9311a Compare November 18, 2024 12:51
magajh
magajh reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BryanttV! I just have a couple of comments

eox_core/settings/test.py Outdated Show resolved Hide resolved
plugins/eox-core.yml Outdated Show resolved Hide resolved
@BryanttV BryanttV requested a review from magajh November 18, 2024 16:07
@BryanttV BryanttV merged commit 30ecea4 into master Nov 18, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magajh magajh magajh approved these changes

@mariajgrimaldi mariajgrimaldi Awaiting requested review from mariajgrimaldi

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BryanttV @mariajgrimaldi @magajh