Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mfe control setting #787

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

MaferMazu
Copy link
Contributor

@MaferMazu MaferMazu commented Nov 29, 2023

Description

This is a cherry-pick from #733 to allow learning MFE by Tenants.

Usage

image

How to test

  • Install eox-tenant https://github.com/eduNEXT/eox-tenant
  • Create at least 2 tenants to test it.
  • If you will test this in an stage environment, and you want to use MFE's by path like the picture, you should install https://github.com/eduNEXT/tutor-contrib-mfe-extensions/tree/master
  • If you are not using MFE's by path, it means you have one main site apps.*, you should create a tenant without course filter for the main site.
  • Set the next two waffle flags: course_home.course_home_use_legacy_frontend and courseware.use_legacy_frontend
  • Add the next settings to the Tenant that will use MFEs:
    • LEARNING_MICROFRONTEND_URL
    • course_org_filter
    • USE_LEARNING_LEGACY_FRONTEND in False
    • "MFE_CONFIG": { "LMS_BASE_URL": "https://tenant-b.nutmeg-live.edunext.link", "LOGIN_URL": "https://tenant-b.nutmeg-live.edunext.link/login", "LOGOUT_URL": "https://tenant-b.nutmeg-live.edunext.link/logout", "REFRESH_ACCESS_TOKEN_ENDPOINT": "https://tenant-b.nutmeg-live.edunext.link/login_refresh" },
  • If you visit a course in the tenant that has the setting USE_LEARNING_LEGACY_FRONTEND in False, you should see the learning MFE, otherwise you should see the legacy frontend.

Where was it tested?

johanseto and others added 2 commits November 29, 2023 17:34
To use the learning mfe now you also need the setting
`USE_LEGACY_FRONTEND` by tenant.

feat: use function to verify lgacy frontend

feat: improve docstring

style: add type hints

feat: update long line for large conditional

feat: move imports for good practices

move the import for utils and toogles and seems withou problems
@Alec4r Alec4r self-requested a review December 6, 2023 17:36
@Alec4r Alec4r marked this pull request as ready for review December 6, 2023 20:14
@Alec4r Alec4r merged commit 026c167 into ednx-release/nuez.master Dec 6, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants