Implementing feedback from code review

edmondop · Aug 1, 2024 · 5af4b62 · 5af4b62
1 parent ec95a77
commit 5af4b62
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/datafusion/optimizer/src/scalar_subquery_to_join.rs b/datafusion/optimizer/src/scalar_subquery_to_join.rs
@@ -393,8 +393,10 @@ mod tests {
     use crate::test::*;
 
     use arrow::datatypes::DataType;
-    use datafusion_expr::test::function_stub::{max, min, sum};
+    use datafusion_expr::test::function_stub::sum;
+
     use datafusion_expr::{col, lit, out_ref_col, scalar_subquery, Between};
+    use datafusion_functions_aggregate::min_max::{max, min};
 
     /// Test multiple correlated subqueries
     #[test]

diff --git a/datafusion/proto/tests/cases/roundtrip_physical_plan.rs b/datafusion/proto/tests/cases/roundtrip_physical_plan.rs
@@ -909,11 +909,13 @@ fn roundtrip_scalar_udf_extension_codec() -> Result<()> {
         )),
         input,
     )?);
-    let aggr_expr = AggregateExprBuilder::new(max_udaf(), 
-    vec![udf_expr.clone() as Arc<dyn PhysicalExpr>])
-        .schema(schema.clone())
-        .name("max")
-        .build()?;
+    let aggr_expr = AggregateExprBuilder::new(
+        max_udaf(),
+        vec![udf_expr.clone() as Arc<dyn PhysicalExpr>],
+    )
+    .schema(schema.clone())
+    .name("max")
+    .build()?;
 
     let window = Arc::new(WindowAggExec::try_new(
         vec![Arc::new(PlainAggregateWindowExpr::new(