Merge pull request #168 from edmcouncil/167-remove-return-1-as-the-en…

…d-of-hygiene-tests Remove 'return 1' as the end of hygiene tests
edmcouncil · Jun 3, 2024 · b84210b · b84210b
2 parents 800ce44 + 70729f5
commit b84210b
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/publisher/product/ontology/build.sh b/publisher/product/ontology/build.sh
@@ -228,14 +228,12 @@ function runHygieneTests() {
       elif [ ${ret} -ne 0 ] ; then
        echo -e "\t\x1b\x5b\x33\x31\x6dERROR\x1b\x5b\x30\x6d: running consistency-check - see 'consistency-check.log'"
        echo $(jq -c ".\"${level}\".\"${SPEC}\".error = \"${ret}\"" "${hygiene_product_tag_root}/consistency-check.json") > "${hygiene_product_tag_root}/consistency-check.json"
-       return 1
       elif jq -e "." &>/dev/null < "${TMPDIR}/output.json" ; then
        displayMissingImports "${TMPDIR}/output.json"
        if [ "$(jq -r ".consistent" < "${TMPDIR}/output.json")" = "true" ] ; then
         echo -e "\t\x1b\x5b\x33\x32\x6d$(echo "Ontology \"${SPEC}\" is consistent."   | tee -a "${hygiene_product_tag_root}/consistency-check.log")\x1b\x5b\x30\x6d"
        else
         echo -e "\t\x1b\x5b\x33\x31\x6d$(echo "Ontology \"${SPEC}\" is inconsistent." | tee -a "${hygiene_product_tag_root}/consistency-check.log")\x1b\x5b\x30\x6d"
-        [[ "${level}" == "error" ]] && return 1
        fi
        echo $(jq -c ".\"${level}\".\"${SPEC}\".output = $(jq -c -r "." "${TMPDIR}/output.json")" "${hygiene_product_tag_root}/consistency-check.json") > "${hygiene_product_tag_root}/consistency-check.json"
       else