Add CMI5 Single AU state save and rendering #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziafazal
reviewed
Jul 27, 2023
There was a problem hiding this comment.
@hinakhadim Thanks for creating this Xblock. I have one suggestion and one question. Could you please look into those?
|
|
||
| <li class="field comp-setting-entry is-set"> | ||
| <div class="wrapper-comp-setting"> | ||
| <label class="label setting-label" for="cmi5_file">{% trans "Upload .zip package" %}</label> |
There was a problem hiding this comment.
change label to "Upload CMI5 package(.zip) or cmi5.xml file"
|
|
||
| <div class="openedx_cmi5_xblock_block"> | ||
| <h3 class="xblock-title mb-2">{{title}}</h3> | ||
| {% if index_page_url %} |
There was a problem hiding this comment.
From where value of index_page_url is being pulled ?
There was a problem hiding this comment.
The index_page_url is pulled from student_view function. Link to line
Talha-Rizwan
force-pushed
the
feat/cmi5-file-save
branch
3 times, most recently
from
2950ba7 to
3e0f75e
Compare
Talha-Rizwan
force-pushed
the
feat/cmi5-file-save
branch
from
e322f39 to
bd92267
Compare
Removed build in ci updated tox.ini
Talha-Rizwan
force-pushed
the
feat/cmi5-file-save
branch
from
7adc10e to
5a7a6f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CMI5 Single AU state save and rendering