Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: public readonly property for CandidFunc #130

Merged

Conversation

witter-deland
Copy link
Contributor

fix #129

@witter-deland witter-deland force-pushed the feature/convert-CandidFunc-to-QueryRequest branch from d8b260f to 6bf03af Compare October 21, 2024 10:59
@witter-deland witter-deland changed the title feat: convert CandidFunc to QueryRequest chore: public readonly property for CandidFunc Oct 21, 2024
Copy link
Collaborator

@Gekctek Gekctek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, would just make serviceInfo public and change it to 'ServiceInfo'

src/Candid/Models/Values/CandidFunc.cs Outdated Show resolved Hide resolved
@witter-deland witter-deland requested a review from Gekctek October 21, 2024 17:21
Copy link
Collaborator

@Gekctek Gekctek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cansiter vs Canister
Goodness, maybe i need to get my eyes checked

Ty

@Gekctek Gekctek merged commit d17263f into edjCase:main Oct 21, 2024
1 check failed
@Gekctek
Copy link
Collaborator

Gekctek commented Oct 21, 2024

witter-deland added a commit to Deland-Labs/ICP.NET that referenced this pull request Oct 24, 2024
* chore: CandidFunc public property

* chore: remove new properties

* fix: typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to call CandidFunc?
2 participants