-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds AWS ElasticBeanstalk deploy instructions to the README #44
Adds AWS ElasticBeanstalk deploy instructions to the README #44
Conversation
The problem with this approach is that you are including your secret inside a docker image and if you want to change the configuration you need to generate a new docker image. IMHO the production configuration shouldn't be part of your image. |
In this case, AWS Elastic Beanstalk will build your image on every deploy. If you want to change the secret, you only have to change However, I agree. I don't like to have these configs in a file on the repository. It would be better to configure this on some environment variable on the server. But I can't find a way to do this yet, with docker. So I created the #45 issue exactly because of that. |
I created a gist explaining how to configure Poxa with SSL on EB. If you think it's relevant, we can put in the documentation or link it. |
Do you mind create a wiki page with this information? I think this is valuable and I appreciate that you shared :) I agree that environment variables are simpler to configure (and usually the "right way" for AWS Beanstalk and ECS) but as I mentioned at #45 it will (soon) be really hard to configure Poxa with environment variables. I'm also investigating how other projects handle this case (Rabbitmq and Riak for example) |
Of course. Let me get this straight. Do you want me to put all the Elastic Beanstalk deploy instructions, including the content of this PR, on a wiki, right? About the environment variables, I understand your concerns. I'm not familiar with this code and even elixir, so, I don't think I can help right now, but, if I have any ideas I will let you know. |
Yes! |
I think I found the perfect example: This example includes files and mount them as part of the volume definition. It's using multiple containers, but I imagine that single container should be pretty similar. |
Interesting, I will try that. Thanks |
I managed to make the deploy work with this config: Dockerrun.aws.json
Not sure if this was what you are expecting @edgurgel. |
That's awesome! That's exactly what I was expecting 👍 |
Ok, I will write the Wiki page. |
Thanks a lot, @RobertoSchneiders 👍 |
No description provided.