fix: Wait for MQTT subscriptions to take effect before returning (#516) #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaton-coreymutter
force-pushed
the
EF-516
branch
from
03a6c46
to
c5e9af2
Compare
…exfoundry#516) MQTTAsync_subscribe() is async. There are some places e.g. startConfigured() where we expect the subscription to be in effect right after this call. So wait for completion before returning. Fixes: edgexfoundry#516 Signed-off-by: Corey Mutter <[email protected]>
eaton-coreymutter
force-pushed
the
EF-516
branch
from
c5e9af2
to
d2bfa6c
Compare
eaton-coreymutter
changed the title
FelixTing
requested changes
Oct 30, 2024
| @@ -73,6 +73,10 @@ static void edgex_bus_mqtt_subscribe (void *ctx, const char *topic) | |||
| { | |||
| iot_log_error (cinfo->lc, "mqtt: unable to subscribe to %s, error code %d", topic, rc); | |||
| } | |||
| else | |||
| { | |||
| MQTTAsync_waitForCompletion(cinfo->client, opts.token, 1000); | |||
There was a problem hiding this comment.
Perhaps we could consider adding a check for the return code of MQTTAsync_waitForCompletion. If the return code is not MQTTASYNC_SUCCESS, logging it could be helpful for diagnosing problems.
There was a problem hiding this comment.
@eaton-coreymutter Just wanted to confirm the idea of adding a return code check for MQTTAsync_waitForCompletion. What are your thoughts on this?
There was a problem hiding this comment.
Yes, it's a good idea, I will add the change soonish, or you are welcome to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MQTTAsync_subscribe() is async. There are some places e.g. startConfigured() where we expect the subscription to be in effect right after this call. So wait for completion before returning.
Fixes: #516
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-c/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
Before and after change, on a busy system, repeatedly have a C-based device service start and upload its devices (deleting them from core-metadata each time), to reproduce the bug in the related issue.
New Dependency Instructions (If applicable)