Redo logging & formatting (again) #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use collection constructor syntax instead for simpleviews (much cleaner!) * Work on beginning of new logging thing.
* Remove most stuff from LogManager, into their own classes & services * Add PlayerTagHelper as an experimental service to avoid dependency loop shenanigans in main classes * Add LogMessages as an english translation * Add ToServerConsole IView extension
…ng logging * Fully add rich logging service * Redo Simpleview to use a specific "Newline" struct for explicit newlines
# Conflicts: # lang/Jailbreak.English/Generic/GenericCommandNotifications.cs # lang/Jailbreak.English/Rebel/RebelNotifications.cs # lang/Jailbreak.English/Teams/RatioNotifications.cs # lang/Jailbreak.English/Warden/WardenNotifications.cs # mod/Jailbreak.Logs/LogsListeners.cs # mod/Jailbreak.Logs/LogsManager.cs # mod/Jailbreak.Logs/LogsServiceExtension.cs # mod/Jailbreak.Rebel/RebelManager.cs # mod/Jailbreak.Teams/Ratio/RatioBehavior.cs # mod/Jailbreak.Warden/Global/WardenBehavior.cs # public/Jailbreak.Formatting/Base/SimpleView.cs # public/Jailbreak.Formatting/Extensions/ViewExtensions.cs # public/Jailbreak.Formatting/Logistics/LanguageConfig.cs # public/Jailbreak.Public/Extensions/ServerExtensions.cs # src/Jailbreak/JailbreakServiceCollection.cs
* TODO: IO listener will only listen for when the breakable does something when it breaks... We need a better way to listen for eg. CTs pursuing vents.
… in PlayerFormatObject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleViewsemantics to be more in line with how they're actually used (use collection-constructor pattern rather than delegate pattern)LogManagerintoILogService,IPlayerTag, and rich variants inJailbreak.Formatting