Disconnected client crashes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make global state eviction slightly more verbose * All format operations will check for a valid client before continuing
MSWS
added a commit
that referenced
this pull request
Feb 6, 2024
* Add rebel notifications * Add rebel notifications * Feat/debug (#19) * Initial stuff for debug * More classes! * Base implementation * Feat/debug (#20) * Initial stuff for debug * More classes! * Base implementation * Verified working * Prevent some crashes when touching disconnected clients (#22) * Make global state eviction slightly more verbose * All format operations will check for a valid client before continuing * Cleanup (#23) * Format * Enforce variable naming scheme * Fix namespaces and nullabilities * Resolve all warnings * Update Github Actions * Fix merge issues --------- Co-authored-by: Mooshua <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client is disconnected, and
ClientPrintFis invoked, libengine will try and dereference a null private field and slip in a puddle of poo.This PR aims to remove some edge cases where disconnected players can be touched by the plugin code. This is not extensive as of yet, just some low-hanging fruit.