Move to localizations

lang/Jailbreak.English/LastRequest/LastRequestMessages.cs

@@ -1,3 +1,5 @@
+using CounterStrikeSharp.API.Core;
+using CounterStrikeSharp.API.Modules.Utils;
 using Jailbreak.Formatting.Base;
 using Jailbreak.Formatting.Logistics;
 using Jailbreak.Formatting.Views;
@@ -15,4 +17,24 @@ public class LastRequestMessages : ILastRequestMessages, ILanguage<Formatting.La
     {
         { "Last Request has been disabled." }
     };
+
+    public IView InvalidLastRequest(string query)
+    {
+        return new SimpleView()
+        {
+            "Invalid Last Request: ",
+            query
+        };
+    }
+
+    public IView InvalidPlayerChoice(CCSPlayerController player, string reason)
+    {
+        return new SimpleView()
+        {
+            "Invalid player choice: ",
+            player,
+            " Reason: ",
+            reason
+        };
+    }
 }

mod/Jailbreak.LastRequest/LastRequestCommand.cs

@@ -4,6 +4,7 @@
 using CounterStrikeSharp.API.Modules.Commands.Targeting;
 using CounterStrikeSharp.API.Modules.Menu;
 using CounterStrikeSharp.API.Modules.Utils;
+using Jailbreak.Formatting.Views;
 using Jailbreak.Public.Behaviors;
 using Jailbreak.Public.Extensions;
 using Jailbreak.Public.Mod.LastRequest;
@@ -14,16 +15,20 @@ namespace Jailbreak.LastRequest;
 
 public class LastRequestCommand : IPluginBehavior
 {
-
     private ILastRequestManager _lrManager;
     private LastRequestMenuSelector menuSelector;
     private LastRequestPlayerSelector playerSelector;
     private BasePlugin plugin;
+    private ILastRequestMessages _messages;
+    private IGenericCommandNotifications _generic;
 
     // css_lr <player> <LRType>
-    public LastRequestCommand(ILastRequestManager manager, ILastRequestFactory factory)
+    public LastRequestCommand(ILastRequestManager manager, ILastRequestMessages messages,
+        IGenericCommandNotifications generic)
     {
         _lrManager = manager;
+        _messages = messages;
+        _generic = generic;
     }
 
     public void Start(BasePlugin plugin)
@@ -65,45 +70,48 @@ public void Command_LastRequest(CCSPlayerController? executor, CommandInfo info)
         }
 
         // Validate LR
-        var type = LRTypeExtensions.FromString(info.GetArg(1));
-        if (type == null)
+        if (!Enum.TryParse<LRType>(info.GetArg(1), true, out var type))
         {
             info.ReplyToCommand("Invalid LR");
             return;
         }
+
         if (info.ArgCount == 2)
         {
             MenuManager.OpenCenterHtmlMenu(plugin, executor, playerSelector.CreateMenu(executor, (LRType)type));
             return;
         }
 
         var target = info.GetArgTargetResult(2);
-        new Target(info.GetArg(2)).GetTarget(executor);
         if (!target.Players.Any())
         {
-            info.ReplyToCommand($"Could not find valid player using {info.GetArg(2)}");
+            _generic.PlayerNotFound(info.GetArg(2));
             return;
         }
 
         if (target.Players.Count > 1)
         {
-            info.ReplyToCommand("Too many players");
+            _generic.PlayerFoundMultiple(info.GetArg(2));
             return;
         }
 
         var player = target.Players.First();
         if (player.Team != CsTeam.CounterTerrorist)
         {
-            info.ReplyToCommand("They're not on CT!");
+            _messages.InvalidPlayerChoice(player, "They're not on CT!");
             return;
         }
 
         if (!player.PawnIsAlive)
         {
-            info.ReplyToCommand("They're not alive!");
+            _messages.InvalidPlayerChoice(player, "They're not alive!");
             return;
         }
 
-        _lrManager.InitiateLastRequest(executor, player, (LRType)type);
+        if (!_lrManager.InitiateLastRequest(executor, player, (LRType)type))
+        {
+            info.ReplyToCommand("An error occurred while initiating the last request. Please try again later.");
+            return;
+        }
     }
 }

mod/Jailbreak.LastRequest/LastRequestManager.cs

@@ -55,10 +55,20 @@ public HookResult OnPlayerDeath(EventPlayerDeath @event, GameEventInfo info)
         if (!player.IsReal())
             return HookResult.Continue;
 
+        if (IsLREnabled)
+        {
+            var activeLr = ((ILastRequestManager)this).GetActiveLR(player);
+            if (activeLr != null)
+            {
+                var isPrisoner = activeLr.prisoner.Slot == player.Slot;
+                EndLastRequest(activeLr, isPrisoner ? LRResult.PrisonerWin : LRResult.GuardWin);
+            }
+        }
+
         if (player.GetTeam() != CsTeam.Terrorist)
             return HookResult.Continue;
 
-        if (CountAlivePrisoners() - 1> config.PrisonersToActiveLR)
+        if (CountAlivePrisoners() - 1 > config.PrisonersToActiveLR)
             return HookResult.Continue;
 
         IsLREnabled = true;
@@ -83,10 +93,26 @@ private bool CountsToLR(CCSPlayerController player)
     public bool IsLREnabled { get; set; }
     public IList<AbstractLastRequest> ActiveLRs { get; } = new List<AbstractLastRequest>();
 
-    public void InitiateLastRequest(CCSPlayerController prisoner, CCSPlayerController guard, LRType type)
+    public bool InitiateLastRequest(CCSPlayerController prisoner, CCSPlayerController guard, LRType type)
+    {
+        try
+        {
+            var lr = factory.CreateLastRequest(prisoner, guard, type);
+            lr.Setup();
+            ActiveLRs.Add(lr);
+            return true;
+        }
+        catch (ArgumentException e)
+        {
+            Console.WriteLine(e);
+            return false;
+        }
+    }
+
+    public bool EndLastRequest(AbstractLastRequest lr, LRResult result)
     {
-        AbstractLastRequest lr = factory.CreateLastRequest(prisoner, guard, type);
-        lr.Setup();
-        ActiveLRs.Add(lr);
+        lr.End(result);
+        ActiveLRs.Remove(lr);
+        return true;
     }
 }

mod/Jailbreak.LastRequest/LastRequests/KnifeFight.cs

@@ -1,3 +1,4 @@
+using CounterStrikeSharp.API;
 using CounterStrikeSharp.API.Core;
 using CounterStrikeSharp.API.Core.Attributes.Registration;
 using Jailbreak.Public.Mod.LastRequest;
@@ -27,6 +28,7 @@ public HookResult OnPlayerDeath(EventPlayerDeath @event, GameEventInfo info)
 
     public override void Setup()
     {
+        Server.PrintToChatAll($"{prisoner.PlayerName} is knife fighting {guard.PlayerName}");
         // Strip weapons, teleport T to CT
         prisoner.RemoveWeapons();
         guard.RemoveWeapons();
@@ -37,13 +39,16 @@ public override void Setup()
 
     public override void Execute()
     {
+        prisoner.PrintToChat("Begin!");
+        guard.PrintToChat("Begin!");
         prisoner.GiveNamedItem("weapon_knife");
         guard.GiveNamedItem("weapon_knife");
         this.state = LRState.Active;
     }
 
     public override void End(LRResult result)
     {
+        Server.PrintToChatAll($"The knife fight ended!");
         this.state = LRState.Completed;
     }
 }

public/Jailbreak.Formatting/Views/ILastRequestMessages.cs

@@ -1,3 +1,4 @@
+using CounterStrikeSharp.API.Core;
 using Jailbreak.Formatting.Base;
 
 namespace Jailbreak.Formatting.Views;
@@ -6,4 +7,6 @@ public interface ILastRequestMessages
 {
     public IView LastRequestEnabled();
     public IView LastRequestDisabled();
+    public IView InvalidLastRequest(string query);
+    public IView InvalidPlayerChoice(CCSPlayerController player, string reason);
 }

public/Jailbreak.Public/Mod/LastRequest/ILastRequestManager.cs

@@ -8,12 +8,17 @@ public interface ILastRequestManager : IPluginBehavior
 {
     public bool IsLREnabled { get; set; }
     public IList<AbstractLastRequest> ActiveLRs { get; }
-
-    void InitiateLastRequest(CCSPlayerController prisoner, CCSPlayerController guard, LRType lrType);
+
+    bool InitiateLastRequest(CCSPlayerController prisoner, CCSPlayerController guard, LRType lrType);
+    bool EndLastRequest(AbstractLastRequest lr, LRResult result);
 
     public bool IsInLR(CCSPlayerController player)
     {
-        return ActiveLRs.Any(lr => lr.guard.Slot == player.Slot || lr.prisoner.Slot == player.Slot);
+        return GetActiveLR(player) != null;
+    }
+
+    public AbstractLastRequest? GetActiveLR(CCSPlayerController player)
+    {
+        return ActiveLRs.FirstOrDefault(lr => lr.guard.Slot == player.Slot || lr.prisoner.Slot == player.Slot);
     }
-
 }