Add SQLite

edgegamers · Sep 7, 2024 · 3b34039 · 3b34039
1 parent 8dbbd98
commit 3b34039
Show file tree

Hide file tree

Showing 5 changed files with 92 additions and 35 deletions.
diff --git a/GangsImpl/AbstractDB/AbstractInstanceManager.cs b/GangsImpl/AbstractDB/AbstractInstanceManager.cs
@@ -8,7 +8,7 @@ namespace GenericDB;
 
 public abstract class AbstractInstanceManager<TK>(string connectionString,
   string table_prefix, bool testing = false) {
-  protected DbConnection Connection;
+  protected DbConnection Connection = null!;
   abstract protected string PrimaryKey { get; }
   private string primaryTypeString => GetDBType(typeof(TK));
 
@@ -19,34 +19,43 @@ public void ClearCache() { }
   public async Task<(bool, TV?)> Get<TV>(TK key, string statId) {
     await createTable<TV>(statId);
     try {
+      var dynamic = new DynamicParameters();
+      dynamic.Add(PrimaryKey, key);
       var result = await Connection.QuerySingleAsync<TV>(
-        $"SELECT {(typeof(TV).IsPrimitive ? statId : getFieldNames<TV>())} FROM {table_prefix}_{statId} WHERE {PrimaryKey} = @{PrimaryKey}",
-        new { GangId = key });
+        $"SELECT {(typeof(TV).IsPrimitive ? statId : GetFieldNames<TV>())} FROM {table_prefix}_{statId} WHERE {PrimaryKey} = @{PrimaryKey}",
+        dynamic);
       return (true, result);
-    } catch (InvalidOperationException) { return (false, default); }
+    } catch (InvalidOperationException e) {
+      if (!e.Message.Contains("Sequence contains no elements")) throw;
+      return (false, default);
+    }
   }
 
-  public async Task<bool> Set<TV>(TK key, string statId, TV value) {
-    await createTable<TV>(statId);
-    var fields = typeof(TV)
-     .GetProperties(BindingFlags.Public | BindingFlags.Instance)
-     .ToList();
-
-    var columns = getFieldNames<TV>();
-    var values  = getFieldNames<TV>("@");
+  virtual protected string GenerateInsertQuery<TV>(string statId,
+    IList<PropertyInfo> properties) {
+    var columns = GetFieldNames<TV>();
+    var values  = GetFieldNames<TV>("@");
 
     if (typeof(TV).IsPrimitive) {
       columns = statId;
       values  = $"@{statId}";
     }
 
     var onDuplicate = string.Join(", ",
-      fields.Select(f => $"{f.Name} = @{f.Name}"));
+      properties.Select(f => $"{f.Name} = @{f.Name}"));
     if (typeof(TV).IsPrimitive) onDuplicate = $"{statId} = @{statId}";
-    var cmd =
+    return
       $"INSERT INTO {table_prefix}_{statId} ({PrimaryKey}, {columns}) VALUES (@{PrimaryKey}, {values}) ON DUPLICATE KEY UPDATE {onDuplicate}";
+  }
 
-    Debug.WriteLine(cmd);
+  public async Task<bool> Set<TV>(TK key, string statId, TV value) {
+    await createTable<TV>(statId);
+
+    var fields = typeof(TV)
+     .GetProperties(BindingFlags.Public | BindingFlags.Instance)
+     .ToList();
+
+    var cmd = GenerateInsertQuery<TV>(statId, fields);
 
     var fieldValues = new DynamicParameters();
     fieldValues.Add("@" + PrimaryKey, key);
@@ -70,7 +79,11 @@ await Connection.ExecuteAsync(
         $"DELETE FROM {table_prefix}_{statId} WHERE {PrimaryKey} = @{PrimaryKey}",
         dynamicParameters);
       return true;
-    } catch (DbException) { return false; }
+    } catch (DbException e) {
+      if (e.Message.Contains("no such table")) return false;
+      if (e.Message.EndsWith("doesn't exist")) return false;
+      throw;
+    }
   }
 
   public void Start(BasePlugin? plugin, bool hotReload) {
@@ -130,7 +143,7 @@ private async Task createTable<TV>(string id) {
     await Connection.ExecuteAsync(cmd);
   }
 
-  private string getFieldNames<TV>(string prefix = "") {
+  protected string GetFieldNames<TV>(string prefix = "") {
     var fields = typeof(TV)
      .GetProperties(BindingFlags.Public | BindingFlags.Instance)
      .ToList();

diff --git a/GangsImpl/SQL/SQLGangInstanceManager.cs → GangsImpl/SQL/SQLInstanceManager.cs b/GangsImpl/SQL/SQLGangInstanceManager.cs → GangsImpl/SQL/SQLInstanceManager.cs
@@ -11,31 +11,27 @@ namespace SQLImpl;
 public class SQLGangInstanceManager(string connectionString,
   string table_prefix, bool testing = false)
   : AbstractInstanceManager<int>(connectionString, table_prefix, testing),
-    IPluginBehavior, IGangStatManager {
+    IGangStatManager {
   override protected string PrimaryKey => "GangId";
 
-  public Task<(bool, TV?)> GetForGang<TV>(int key, string statId) {
-    return Get<TV>(key, statId);
-  }
+  public Task<(bool, TV?)> GetForGang<TV>(int key, string statId)
+    => Get<TV>(key, statId);
 
-  public Task<bool> SetForGang<TV>(int gangId, string statId, TV value) {
-    return Set(gangId, statId, value);
-  }
+  public Task<bool> SetForGang<TV>(int gangId, string statId, TV value)
+    => Set(gangId, statId, value);
 
-  public Task<bool> RemoveFromGang(int gangId, string statId) {
-    return Remove(gangId, statId);
-  }
+  public Task<bool> RemoveFromGang(int gangId, string statId)
+    => Remove(gangId, statId);
 
-  override protected DbConnection CreateDbConnection(string connectionString) {
-    return new MySqlConnection(connectionString);
-  }
+  override protected DbConnection CreateDbConnection(string connectionString)
+    => new MySqlConnection(connectionString);
 }
 
 public class SQLPlayerInstanceManager(string connectionString,
   string table_prefix, bool testing = false)
   : AbstractInstanceManager<ulong>(connectionString, table_prefix, testing),
     IPlayerStatManager {
-  override protected string PrimaryKey => "GangId";
+  override protected string PrimaryKey => "Steam";
 
   public Task<(bool, TV?)> GetForPlayer<TV>(ulong steam, string statId) {
     return Get<TV>(steam, statId);
@@ -49,7 +45,6 @@ public Task<bool> RemoveFromPlayer(ulong steam, string statId) {
     return Remove(steam, statId);
   }
 
-  override protected DbConnection CreateDbConnection(string connectionString) {
-    return new MySqlConnection(connectionString);
-  }
+  override protected DbConnection CreateDbConnection(string connectionString)
+    => new MySqlConnection(connectionString);
 }
diff --git a/GangsImpl/SQLite/SQLiteInstanceManager.cs b/GangsImpl/SQLite/SQLiteInstanceManager.cs
@@ -0,0 +1,45 @@
+using System.Data.Common;
+using System.Reflection;
+using GangsAPI.Services.Gang;
+using GenericDB;
+using Microsoft.Data.Sqlite;
+
+namespace SQLite;
+
+public class SQLiteGangInstanceManager(string connectionString,
+  string tablePrefix, bool testing = false)
+  : AbstractInstanceManager<int>(connectionString, tablePrefix, testing),
+    IGangStatManager {
+  private readonly string myTablePrefix = tablePrefix;
+  override protected string PrimaryKey => "GangId";
+
+  override protected DbConnection CreateDbConnection(string connectionString) {
+    return new SqliteConnection(connectionString);
+  }
+
+  override protected string GenerateInsertQuery<TV>(string statId,
+    IList<PropertyInfo> properties) {
+    var columns = GetFieldNames<TV>();
+    var values  = GetFieldNames<TV>("@");
+
+    if (typeof(TV).IsPrimitive) {
+      columns = statId;
+      values  = $"@{statId}";
+    }
+
+    var onDuplicate = string.Join(", ",
+      properties.Select(f => $"{f.Name} = @{f.Name}"));
+    if (typeof(TV).IsPrimitive) onDuplicate = $"{statId} = @{statId}";
+    return
+      $"INSERT INTO {myTablePrefix}_{statId} ({PrimaryKey}, {columns}) VALUES (@{PrimaryKey}, {values}) ON CONFLICT({PrimaryKey}) DO UPDATE SET {onDuplicate}";
+  }
+
+  public Task<(bool, TV?)> GetForGang<TV>(int key, string statId)
+    => Get<TV>(key, statId);
+
+  public Task<bool> SetForGang<TV>(int gangId, string statId, TV value)
+    => Set(gangId, statId, value);
+
+  public Task<bool> RemoveFromGang(int gangId, string statId)
+    => Remove(gangId, statId);
+}
diff --git a/GangsTest/API/Services/Stat/Instance/Gang/TestData.cs b/GangsTest/API/Services/Stat/Instance/Gang/TestData.cs
@@ -2,6 +2,7 @@
 using GangsAPI.Services.Gang;
 using Mock;
 using SQLImpl;
+using SQLite;
 
 namespace GangsTest.API.Services.Stat.Instance.Gang;
 
@@ -10,7 +11,9 @@ public class TestData : IEnumerable<object[]> {
     new MockInstanceStatManager(),
     new SQLGangInstanceManager(
       Environment.GetEnvironmentVariable("DB_GANGS_CONNECTION")
-      ?? "Host=localhost;User=root;Database=gangs", "gang_inst_stats", true)
+      ?? "Host=localhost;User=root;Database=gangs", "gang_inst_stats", true),
+    new SQLiteGangInstanceManager("Data Source=:memory:", "gang_inst_stats",
+      true)
   ];
 
   public TestData() {

diff --git a/GangsTest/API/Services/Stat/Instance/TestParent.cs b/GangsTest/API/Services/Stat/Instance/TestParent.cs
@@ -48,6 +48,7 @@ public bool Equals(IStat<int>? other) {
 
   protected class Reputation(int Positive, int negative)
     : IEquatable<Reputation> {
+    public Reputation() : this(0, 0) { }
     public int Positive { get; } = Positive;
     public int Negative { get; } = negative;