fix(datepicker): Changed handling of value change #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you in advance that you make this library.
I tried to resolve bug i have found.
From angular docs for
ControlValueAccessor:
writeValue
- This method will be called by the forms API to write to the view when programmatic (model -> view) changes are requested.onChange
- ... update the form model when values propagate from the view (view -> model).There was call from
writeValue
method toonChange
event. That makes control dirty for initial value. I have added new eventonViewValueChange
used to update input value.I have changed how value is set from input to component. Changing value trough input changes model -> should fire
onChange
event and not callwriteValue
.I made little change in documentation - IMHO there was missing ngModel atribute.