-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added compareWith input for select #310
Open
Gimly
wants to merge
2
commits into
edcarroll:master
Choose a base branch
from
Gimly:297-SelectAddCompareWith
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,9 @@ export abstract class SuiSelectBase<T, U> implements AfterContentInit, OnDestroy | |
// Keep track of all of the subscriptions to the selected events on the rendered options. | ||
private _renderedSubscriptions:Subscription[]; | ||
|
||
// Method used to compare the type of property of the option used as the value. | ||
private _compareWith:(o1:U, o2:U) => boolean; | ||
|
||
// Sets the Semantic UI classes on the host element. | ||
@HostBinding("class.ui") | ||
@HostBinding("class.dropdown") | ||
|
@@ -132,6 +135,13 @@ export abstract class SuiSelectBase<T, U> implements AfterContentInit, OnDestroy | |
} | ||
} | ||
|
||
@Input() | ||
public set compareWith(fn:(o1:U, o2:U) => boolean) { | ||
if (fn) { | ||
this._compareWith = fn; | ||
} | ||
} | ||
|
||
public get filteredOptions():T[] { | ||
return this.searchService.results; | ||
} | ||
|
@@ -331,6 +341,9 @@ export abstract class SuiSelectBase<T, U> implements AfterContentInit, OnDestroy | |
public abstract selectOption(option:T):void; | ||
|
||
protected findOption(options:T[], value:U):T | undefined { | ||
if (this._compareWith) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think rather than checking to see if the function has been assigned, it would be cleaner to initialise this property in the constructor with |
||
return options.find(o => this._compareWith(value, this.valueGetter(o))); | ||
} | ||
// Tries to find an option in options array | ||
return options.find(o => value === this.valueGetter(o)); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you name this function
optionsCompare
please to get it inline withoptionsLookup
?