-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(message): Add notification functionality #242
base: v0.10.0
Are you sure you want to change the base?
Conversation
@mcosta74 remade the PR manually so the diff is no longer stupid. |
What is the status on this? @edcarroll do you need extra hands? |
@harogaston component is fully implemented, just want some feedback on the interface and how it works 😄 Check out the test component which has an active demo |
as per gitter
for (1) and (2) I basically think if you could make a notification have the same ui as a message that would be great , as it would handle the colors, icons etc |
is it likely that this pr will make it into the main codebase ? Been waiting on it for some time now ;) |
PR is WIP
This PR adds toast style notifications to the message components, as outlined in #103.
Will update this comment with more info when I have more time.