Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] budget_control #439

Merged
merged 12 commits into from
Aug 1, 2024
Merged

[16.0][MIG] budget_control #439

merged 12 commits into from
Aug 1, 2024

Conversation

Saran440
Copy link
Collaborator

@Saran440 Saran440 commented Jul 18, 2024 •
edited
Loading

TO DO:

  • Carry Forward Commit
    • Improve budget carry forward - carry not all document
    • Fix - domain carry forward in expense, purchase is not correct
  • Carry Forward Balance

Edit 1:

  • Change amount_commit field from Float to Json because analytic_distribution can select more than 1

Edit 2:

  • Improved budget carry forward in method _get_base_domain from search() to direct query database

Saran440 and others added 11 commits July 18, 2024 13:42
@Saran440
[15.0][ADD] budget_control
1b83a46
@Saran440
[FIX] budget_control: close budget with fwd_analytic_account_id
b508da8
@Saran440
[FIX] budget_control: check budget with sudo()
e0a5526
@Saran440
[FIX] budget_control_purchase: add precommit check budget function
b799bf0 
Support for other module can check budget precommit in PO and Actual.
Standard will not check precommit because PO and Actual has next state draft is commit budget.
So, precommit budget is not need.

However, extensnion module like 'base_tier_validation_check_budget' can check budget in state draft.
we will improved base module budget for support precommit check budget
@Saran440
[FIX] check budget with period
97abef5
@Saran440
[FIX] error no variable
562c72e
@Saran440
[FIX] budget_control: error no date commit on convert currency amount
dd45000
@Saran440
[FIX] budget_control: not check required analytic with display_type
12d2f4c
@Saran440
[FIX] pre-commit
8cb110a
@Saran440
[FIX] budget_control: commit budget revenue case
655fd1f
@Saran440
[IMP] budget_control: pre-commit stuff
0dbca90
This was referenced Jul 26, 2024
Merged
Merged
Merged
@ps-tubtim
Copy link
Collaborator

In budget control view, Date Range field should show in one line.

Selection_084

@Saran440
Copy link
Collaborator Author

Saran440 commented Aug 1, 2024

@ps-tubtim แก้ไขแล้วครับ แต่ไม่สามารถขยับเข้ามาใกล้ขึ้นได้ เพราะว่า widget date มันเผื่อความยาวสำหรับ Time ด้วย
Selection_022

แก้ไข widget ให้แสดงกรณี analytic มากกว่า 1 แล้ว
Selection_021

@Saran440 Saran440 merged commit 051c1b3 into 16.0 Aug 1, 2024
6 checks passed
@Saran440 Saran440 deleted the 16.0-mig-budget_control branch September 4, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saran440 @ps-tubtim