Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of expressions and arguments to C++ #271

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

joobog
Copy link
Collaborator

@joobog joobog commented Nov 19, 2024

@shahramn shahramn self-assigned this Nov 19, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.88889% with 197 lines in your changes missing coverage. Please review.

Project coverage is 87.70%. Comparing base (6592ae4) to head (1a2b643).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/expression/grib_expression_class_is_integer.cc 56.86% 22 Missing ⚠️
src/expression/grib_expression_class_is_in_dict.cc 76.38% 17 Missing ⚠️
src/expression/grib_expression.cc 20.00% 16 Missing ⚠️
src/expression/grib_expression_class_is_in_list.cc 81.17% 16 Missing ⚠️
src/expression/grib_expression_class_logical_or.cc 82.45% 10 Missing ⚠️
src/expression/grib_expression_class_accessor.cc 86.88% 8 Missing ⚠️
src/expression/grib_expression_class_length.cc 81.81% 8 Missing ⚠️
src/expression/grib_expression_class_sub_string.cc 73.33% 8 Missing ⚠️
src/expression/grib_expression_class_unop.cc 74.19% 8 Missing ⚠️
src/geo_nearest/grib_nearest_class_reduced.cc 63.63% 8 Missing ⚠️
... and 30 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #271      +/-   ##
===========================================
- Coverage    87.74%   87.70%   -0.05%     
===========================================
  Files          808      826      +18     
  Lines        62084    61998      -86     
  Branches     11021    10998      -23     
===========================================
- Hits         54478    54377     -101     
- Misses        7606     7621      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants