Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD-80276 adding type=em/es for class=rr #242

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

richard-mladek
Copy link
Contributor

@shahramn
Copy link
Collaborator

shahramn commented Sep 3, 2024

Why is the centre set to 82 (Sweden) ?

@shahramn shahramn requested review from shahramn and rdosinski and removed request for shahramn September 3, 2024 08:27
@richard-mladek
Copy link
Contributor Author

richard-mladek commented Sep 3, 2024

Why is the centre set to 82 (Sweden) ?

Good question. At the moment it was reqjuired only for that centre but I have asked about the scope our data providers now.
I have created this pull request & ECC Jira as a starting point for first tests in scratch etc. It is fine to wait a bit, until I get the answers and update that definition if needeed. Thanks!

@shahramn shahramn self-assigned this Sep 3, 2024
@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Sep 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (9179608) to head (42a3609).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #242   +/-   ##
========================================
  Coverage    87.83%   87.83%           
========================================
  Files          776      776           
  Lines        62461    62461           
  Branches     11024    11024           
========================================
  Hits         54863    54863           
  Misses        7598     7598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahramn shahramn requested a review from sebvi September 3, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants