Fix dimensionless unit formatting #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: James Varndell <[email protected]>
JamesVarndell
added a commit
that referenced
this pull request
Nov 17, 2024
* 12 support non latlon grib grids (#16) * Adds support for non-lat-lon GRIB data points * Re-enable automatic legend titles with proper fallback if no metadata found * QA tweaks * Rollback version of micromamba used with unit tests to v12 * Testing latest micromamba * Migrate to new setup-micromamba * Improve levels auto_range with proper symmetry (#17) * Improve levels auto_range with proper symmetry * Ensure symmetry around arbitrary divergence point * Removes obsolete math import --------- Co-authored-by: James Varndell <[email protected]> * Fix datetime metadata for xarray for single-time datasets (#18) * Only check for unstructured grid if normal plotting fails * Adds convience save function at subplot level * Fix earthkit mutably messing up an xarray's longitude (#22) * Fix dimensionless unit formatting (#19) * Fix dimensionless unit formatting * Update src/earthkit/plots/metadata/units.py Co-authored-by: James Varndell <[email protected]> --------- Co-authored-by: James Varndell <[email protected]> * Adds plugin support for Python 3.9 (#23) * Feature/interactive plots (#25) * Moves interactive plots into earthkit.plots.interactive * Adds plotly to requirements * Moves interactive plots into earthkit.plots.interactive * Remove empty notebook * QA tweaks * Adds default style to improve look and feel with >5 quantiles * Adds default style to improve look and feel with >5 quantiles * Adds docstrings * Adds tests for interactive plots * QA tweaks * Feature/vertical plots (#26) * Moves interactive plots into earthkit.plots.interactive * Adds plotly to requirements * Moves interactive plots into earthkit.plots.interactive * Remove empty notebook * QA tweaks * Adds default style to improve look and feel with >5 quantiles * Adds default style to improve look and feel with >5 quantiles * Adds docstrings * Adds tests for interactive plots * QA tweaks * Adds better support for interactive vertical plots --------- Co-authored-by: Juniper Tyree <[email protected]>
JamesVarndell
added a commit
that referenced
this pull request
Nov 19, 2024
* 12 support non latlon grib grids (#16) * Adds support for non-lat-lon GRIB data points * Re-enable automatic legend titles with proper fallback if no metadata found * QA tweaks * Rollback version of micromamba used with unit tests to v12 * Testing latest micromamba * Migrate to new setup-micromamba * Improve levels auto_range with proper symmetry (#17) * Improve levels auto_range with proper symmetry * Ensure symmetry around arbitrary divergence point * Removes obsolete math import --------- Co-authored-by: James Varndell <[email protected]> * Fix datetime metadata for xarray for single-time datasets (#18) * Only check for unstructured grid if normal plotting fails * Adds convience save function at subplot level * Fix earthkit mutably messing up an xarray's longitude (#22) * Fix dimensionless unit formatting (#19) * Fix dimensionless unit formatting * Update src/earthkit/plots/metadata/units.py Co-authored-by: James Varndell <[email protected]> --------- Co-authored-by: James Varndell <[email protected]> * Adds plugin support for Python 3.9 (#23) * Feature/interactive plots (#25) * Moves interactive plots into earthkit.plots.interactive * Adds plotly to requirements * Moves interactive plots into earthkit.plots.interactive * Remove empty notebook * QA tweaks * Adds default style to improve look and feel with >5 quantiles * Adds default style to improve look and feel with >5 quantiles * Adds docstrings * Adds tests for interactive plots * QA tweaks * Feature/vertical plots (#26) * Moves interactive plots into earthkit.plots.interactive * Adds plotly to requirements * Moves interactive plots into earthkit.plots.interactive * Remove empty notebook * QA tweaks * Adds default style to improve look and feel with >5 quantiles * Adds default style to improve look and feel with >5 quantiles * Adds docstrings * Adds tests for interactive plots * QA tweaks * Adds better support for interactive vertical plots * Bugfix/numpy input (#29) * Adds numpy array plotting example * Fixes bug when detecting z-values from numpy input * Fixes bug when detecting x and y from irregular grid data * Adds extra test for numpy z-detection from data argument --------- Co-authored-by: Juniper Tyree <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pint, unlike cf-units, collapses dimensionless units. The current formatting then returns a
"$$"label, which matplotlib cannot handle correctly. The fix checks for dimensionless units explicitly.