-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend: Deprecate OFP and purge from test base #411
Conversation
The effectively remove all parametrised test from the test base.
This should make it unavailable to all tests, but keep the basic functionality intact.
3991d14
to
dc6ce03
Compare
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/411/index.html |
dc6ce03
to
f465077
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
- Coverage 95.96% 93.04% -2.92%
==========================================
Files 198 198
Lines 39320 39320
==========================================
- Hits 37734 36587 -1147
- Misses 1586 2733 +1147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tests all passing, but coverage is decreased (as expected). Farewell old friend. 🫡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, this is fantastic and sad and soothening and so many mixed feelings...
As discussed offline, I have captured the indirect coverage regressions that are incurred from this in #406 (comment)
These should be taken care of when the factual removal of OFP is happening
Note: Just testing for now...As described in #209 , this PR deprecates the OFP frontend and adds a warning to the central OFP parse method. It also purges the
OFP
symbol from the outward-facing API and the test base (including theavailable_frontends()
utiltiy), leaving internal mechanics to rely on the explicit mention ofFrontend.OFP
.Please note that the frontend itself is still present and functional, but it's use is now discouraged.