Fix overflows up to at least tco1279 #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasm91
changed the title
lukasm91
force-pushed
the
fix-overflow
branch
from
dd1e3bb
to
8622da1
Compare
wdeconinck
reviewed
Oct 29, 2024
| enddo | ||
| end subroutine | ||
| subroutine ext_acc_delete(ptrs, stream) | ||
| use openacc, only: acc_async_sync, acc_delete |
There was a problem hiding this comment.
Why remove acc_delete? It is still called below.
There was a problem hiding this comment.
that is a stupid typo... it should not be called. I had to switch to clauses because acc_delete only takes int32, not int64. This code deallocated nothing :D I will test if everything properly deallocates after #151 has been merged).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one more change that Olivier ported from my branch to his branch, and now I am taking it to develop.
The upper end of the sizes that this allows is certainly more "theoretical" because we can't run simulations with it, but even for real use-cases, we might see overflows without this, and those can be very difficult to spot. With one rank, we can grow to very large domains, with multiple ranks, at some point we run into overflows of the MPI buffers, those are properly diagnosed.
This will conflict with #161 , but should be trivial to resolve.