Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX-eclipsesource#2386] Add support for Angular 19 #2391

Conversation

laurentgrangier
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for jsonforms-examples failed.

Name Link
🔨 Latest commit c582a88
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/67448a42b9f0a500085d2a57

@laurentgrangier
Copy link
Contributor Author

@lucas-koehler or @sdirix Could you please take a look at the merge request? I don't understand what are the problems with the build.

@sdirix
Copy link
Member

sdirix commented Nov 22, 2024

There seems to be two issues:

Build of example app of Angular Material fails

The issue seems to be here. The example app build does not enter the success state and therefore returns 1, indicating an error.

We're using an Angular builder here, it likely changed a bit between versions.

Angular Material tests fail

22 11 2024 15:56:20.542:ERROR [karma-server]: Error: Found 1 load error
at Server. (/home/runner/work/jsonforms/jsonforms/node_modules/.pnpm/[email protected]/node_modules/karma/lib/server.js:243:26)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants