Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Hono 2.6.0 #538

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Update to Hono 2.6.0 #538

merged 3 commits into from
Jun 20, 2024

Conversation

sophokles73
Copy link
Member

Also removed @ctron as chart maintainer because he no longer works on Hono.

Addresses #537

@sophokles73 sophokles73 added enhancement New feature or request Hono labels Jun 3, 2024
@sophokles73 sophokles73 requested a review from calohmn as a code owner June 3, 2024 06:12
@sophokles73 sophokles73 force-pushed the update_to_hono_2.6.0 branch from 2fb5002 to ac93771 Compare June 5, 2024 06:13
@sophokles73
Copy link
Member Author

@calohmn I have added the proposed changes. Thanks for spotting 👍

@sophokles73
Copy link
Member Author

I had tested the chart with locally built 2.6.0-SNAPSHOT images (using the honoImagesTag helm install parameter) right before the 2.6.0 release and saw the need to adapt the Command Router image name

You are raising a valid point. For local testing and deploying using the chart, it would indeed be helpful to use the new image names. I will change that ...

@sophokles73 sophokles73 force-pushed the update_to_hono_2.6.0 branch from ac93771 to 016f16a Compare June 5, 2024 06:58
Also removed ctron as chart maintainer because he no longer works on
Hono.
@sophokles73 sophokles73 force-pushed the update_to_hono_2.6.0 branch from 016f16a to ecc2881 Compare June 19, 2024 05:53
@sophokles73
Copy link
Member Author

@calohmn I have pushed corresponding changes ...

Copy link
Contributor

@calohmn calohmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophokles73 sophokles73 merged commit a61510c into master Jun 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants