Allow other database than mysql #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow to specify a full springDatasourceUrl instead of create url from springDatasourceHost and springDatasourceDb. Signed-off-by: Florian Bezannier <[email protected]>
|
I updated chart version, workflow should pass. |
calohmn
reviewed
Nov 13, 2023
Signed-off-by: Florian Bezannier <[email protected]>
Signed-off-by: Florian Bezannier <[email protected]>
flobz
force-pushed
the
hawbkit_db_url
branch
from
f229514 to
07b76e7
Compare
|
@strailov Any comments on this? |
|
Nope, looks good to me. |
avgustinmm
reviewed
Nov 15, 2023
Co-authored-by: Avgustin Marinov <[email protected]>
|
@avgustinmm I apply your suggestion, can we merge ? |
|
I'm not a committer in the project. |
calohmn
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to specify a full springDatasourceUrl instead of create url from springDatasourceHost and springDatasourceDb.