Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#506][#507][#510] Apply Hono chart fixes/improvements #511

Merged
merged 7 commits into from
Sep 25, 2023

Conversation

calohmn
Copy link
Contributor

@calohmn calohmn commented Sep 23, 2023

This fixes #506, #507, #510 and includes further minor fixes and improvements.

Included commits:

This lets these files be detected by the IntelliJ IDEA
Kubernetes plugin.

Signed-off-by: Carsten Lohmann <[email protected]>
…b values.

Enabling the configured mongoDB host to contain the release name reference.

Signed-off-by: Carsten Lohmann <[email protected]>
Using '.Subcharts.<chart-name>' instead of building a dict with subchart Values manually.

Signed-off-by: Carsten Lohmann <[email protected]>
Signed-off-by: Carsten Lohmann <[email protected]>
@calohmn calohmn added the Hono label Sep 23, 2023
@calohmn calohmn requested a review from sophokles73 September 23, 2023 10:37
Copy link
Member

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calohmn calohmn merged commit 320581f into eclipse:master Sep 25, 2023
@calohmn calohmn deleted the PR/hono_chart_fixes branch September 25, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable using non-Hono-chart mongoDB with name based on ReleaseName
2 participants