[#482] Fix wrong MongoDB hostname; fix MongoDB health checks. #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Hono devices registry not being able to connect to the MongoDB instance because it used the wrong hostname. Also fixes MongoDB not getting ready because the health checks took too long and caused OOM errors. Also restrict Hono chart dependency version range (needed for upcoming changes addressing eclipse#430). Signed-off-by: Carsten Lohmann <[email protected]>
calohmn
added
bug
This was referenced Aug 10, 2023
|
@sophokles73 Could you have a look? |
sophokles73
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
LGTM
Maybe we could use the tool suggested in bitnami/charts#10264 (comment) for doing the healthcheck instead?
However, this is something that we might want to add to the Hono and Ditto charts in separate PRs ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #482 .
Fixes Hono devices registry not being able to connect to the MongoDB instance because it used the wrong hostname. Also fixes MongoDB not getting ready because the health checks took too long and caused OOM errors.
Also restrict Hono chart dependency version range (needed for upcoming changes addressing #430).