Allow overriding release name

charts/hono/Chart.yaml

@@ -15,7 +15,7 @@ name: hono
 description: |
   Eclipse Hono™ provides remote service interfaces for connecting large numbers of IoT devices to a back end and
   interacting with them in a uniform way regardless of the device communication protocol.
-version: 2.4.4
+version: 2.5.0
 # Version of Hono being deployed by the chart
 appVersion: 2.4.0
 keywords:

charts/hono/README.md

@@ -102,6 +102,9 @@ helm uninstall eclipse-hono -n hono
 The command removes all the Kubernetes components associated with the chart and deletes the release.
 
 ## Release Notes
+### 2.5.0
+
+* Allow customizing the pod/service names irrespective of .Release.Name.
 
 ### 2.4.4
 
@@ -403,7 +406,7 @@ amqpMessagingNetworkExample:
 
 # mount (existing) Kubernetes secret which contains
 # credentials for connecting to AMQP network
-# into Command Router and protocol adapter containers 
+# into Command Router and protocol adapter containers
 commandRouterService:
   extraVolumes:
   - name: "amqp-network"

charts/hono/config/infinispan/hono-data-grid.xml

@@ -1,14 +1,14 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!-- 
+<!--
     Copyright (c) 2020, 2022 Contributors to the Eclipse Foundation
-   
+
     See the NOTICE file(s) distributed with this work for additional
     information regarding copyright ownership.
-   
+
     This program and the accompanying materials are made available under the
     terms of the Eclipse Public License 2.0 which is available at
     http://www.eclipse.org/legal/epl-2.0
-   
+
     SPDX-License-Identifier: EPL-2.0
  -->
 <infinispan
@@ -84,7 +84,7 @@
         <hotrod-connector name="hotrod">
           <authentication security-realm="ApplicationRealm">
             <sasl mechanisms="SCRAM-SHA-512 SCRAM-SHA-384 DIGEST-SHA-512 DIGEST-SHA-384 DIGEST-MD5"
-                  server-name='{{ printf "%s-data-grid" .Release.Name }}'
+                  server-name='{{ printf "%s-data-grid" (include "hono.fullname" .) }}'
                   qop="auth" />
           </authentication>
         </hotrod-connector>

charts/hono/config/router/qdrouterd.json

@@ -1,6 +1,6 @@
 [
   ["router", {
-    "id": "{{ .Release.Name }}.Example.Router",
+    "id": "{{ include "hono.fullname" . }}.Example.Router",
     "mode": "standalone",
     "workerThreads": 3
   }],
@@ -13,7 +13,7 @@
 
   ["authServicePlugin", {
     "name": "Hono Auth",
-    "host": "{{ .Release.Name }}-service-auth",
+    "host": "{{ include "hono.fullname" . }}-service-auth",
     "port": 5671,
     "sslProfile": "auth-server-profile"
   }],
@@ -92,7 +92,7 @@
     "host": "{{ .Values.amqpMessagingNetworkExample.broker.servicebus.host }}",
     "idleTimeoutSeconds": 120
     {{- else }}
-    "host": "{{ .Release.Name }}-artemis",
+    "host": "{{ include "hono.fullname" . }}-artemis",
     "verifyHostname": false
     {{- end }}
   }],

charts/hono/example/add_example_data_device_registry.sh

@@ -11,7 +11,7 @@
 #
 # SPDX-License-Identifier: EPL-2.0
 #*******************************************************************************
-HTTP_BASE_URL="http://{{ .Release.Name }}-service-device-registry:8080/v1"
+HTTP_BASE_URL="http://{{ include "hono.fullname" . }}-service-device-registry:8080/v1"
 
 check_status() {
   EXIT_STATUS=$1

charts/hono/templates/NOTES.txt

@@ -14,41 +14,41 @@ The output should look similar to this:
 
 NAME                                       {{ "READY   STATUS    RESTARTS   AGE" | indent ( len .Release.Name ) }}
 {{- if .Values.adapters.amqp.enabled }}
-{{ .Release.Name }}-adapter-amqp-65cfb4d675-g5wn4             1/1     Running   0          5m50s
+{{ include "hono.fullname" . }}-adapter-amqp-65cfb4d675-g5wn4             1/1     Running   0          5m50s
 {{- end }}
 {{- if .Values.adapters.coap.enabled }}
-{{ .Release.Name }}-adapter-coap-786b784f47-qx9tg             1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-adapter-coap-786b784f47-qx9tg             1/1     Running   0          5m51s
 {{- end }}
 {{- if .Values.adapters.http.enabled }}
-{{ .Release.Name }}-adapter-http-66bd6bb89c-mng5t             1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-adapter-http-66bd6bb89c-mng5t             1/1     Running   0          5m51s
 {{- end }}
 {{- if .Values.adapters.lora.enabled }}
-{{ .Release.Name }}-adapter-lora-341fca588c-1hl8n             1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-adapter-lora-341fca588c-1hl8n             1/1     Running   0          5m51s
 {{- end }}
 {{- if .Values.adapters.mqtt.enabled }}
-{{ .Release.Name }}-adapter-mqtt-765fcd578b-5rl7n             1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-adapter-mqtt-765fcd578b-5rl7n             1/1     Running   0          5m51s
 {{- end }}
 {{- if ( has "amqp" .Values.messagingNetworkTypes ) }}
-{{ .Release.Name }}-artemis-f8f7dc7f4-864cj                   1/1     Running   0          5m51s
-{{ .Release.Name }}-dispatch-router-6c77dc78bd-hjn4l          1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-artemis-f8f7dc7f4-864cj                   1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-dispatch-router-6c77dc78bd-hjn4l          1/1     Running   0          5m51s
 {{- end }}
 {{- if ( has "kafka" .Values.messagingNetworkTypes ) }}
-{{ .Release.Name }}-kafka-0                                   1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-kafka-0                                   1/1     Running   0          5m51s
 {{- end }}
 {{- if all .Values.deviceRegistryExample.enabled ( eq .Values.deviceRegistryExample.type "mongodb" ) }}
-{{ .Release.Name }}-monogodb-server-77ffb85c97-78554          1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-monogodb-server-77ffb85c97-78554          1/1     Running   0          5m51s
 {{- end }}
-{{ .Release.Name }}-service-auth-84d9695cfc-5wlfh             1/1     Running   0          5m51s
-{{ .Release.Name }}-service-command-router-687fd4fbcf-7527b   1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-service-auth-84d9695cfc-5wlfh             1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-service-command-router-687fd4fbcf-7527b   1/1     Running   0          5m51s
 {{- if .Values.deviceRegistryExample.enabled }}
 {{- if eq .Values.deviceRegistryExample.type "embedded" }}
-{{ .Release.Name }}-service-device-registry-0                 1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-service-device-registry-0                 1/1     Running   0          5m51s
 {{- else }}
-{{ .Release.Name }}-service-device-registry-64d645dd9c-q9c5q  1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-service-device-registry-64d645dd9c-q9c5q  1/1     Running   0          5m51s
 {{- end }}
 {{- end }}
 {{- if ( has "kafka" .Values.messagingNetworkTypes ) }}
-{{ .Release.Name }}-zookeeper-0                               1/1     Running   0          5m51s
+{{ include "hono.fullname" . }}-zookeeper-0                               1/1     Running   0          5m51s
 {{- end }}
 
 Once all pods have reached the READY state, you can start using Hono.

charts/hono/templates/_helpers.tpl

@@ -13,10 +13,14 @@
 {{/* vim: set filetype=mustache: */}}
 
 {{/*
-Expand the name of the chart.
+Expand the name of the chart using the Chart name.
+If .Values.nameOverride is set use that instead of the Chart Name.
+We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
 */}}
 {{- define "hono.name" -}}
-  {{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" -}}
+  {{- $nameOverride := .Values.nameOverride -}}
+  {{- $name := empty $nameOverride | ternary .Chart.Name $nameOverride -}}
+  {{- trunc 63 $name | trimSuffix "-" -}}
 {{- end -}}
 
 {{/*
@@ -25,10 +29,12 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
 If release name contains chart name it will be used as a full name.
 */}}
 {{- define "hono.fullname" -}}
-  {{- if .Values.fullnameOverride -}}
-    {{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" -}}
+  {{- $fullnameOverride := .Values.fullnameOverride -}}
+  {{- if $fullnameOverride  -}}
+    {{- $fullnameOverride | trunc 63 | trimSuffix "-" -}}
   {{- else -}}
-    {{- $name := default .Chart.Name .Values.nameOverride -}}
+    {{- $nameOverride := .Values.nameOverride -}}
+    {{- $name := empty $nameOverride | ternary .Chart.Name $nameOverride -}}
     {{- if contains $name .Release.Name -}}
       {{- .Release.Name | trunc 63 | trimSuffix "-" -}}
     {{- else -}}
@@ -84,13 +90,16 @@ The scope passed in is expected to be a dict with keys
 
 {{/*
 Add standard labels for resources as recommended by Helm best practices.
+
+The scope passed in is expected to be a dict with keys
+- (mandatory) "dot": the root (".") scope
 */}}
 {{- define "hono.std.labels" -}}
-app.kubernetes.io/name: {{ include "hono.name" . | quote }}
-helm.sh/chart: {{ include "hono.chart" . | quote }}
-app.kubernetes.io/managed-by: {{ .Release.Service | quote }}
-app.kubernetes.io/instance: {{ .Release.Name | quote }}
-app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
+app.kubernetes.io/name: {{ include "hono.name" .dot | quote }}
+helm.sh/chart: {{ include "hono.chart" .dot | quote }}
+app.kubernetes.io/managed-by: {{ .dot.Release.Service | quote }}
+app.kubernetes.io/instance: {{ .dot.Release.Name | quote }}
+app.kubernetes.io/version: {{ .dot.Chart.AppVersion | quote }}
 {{- end }}
 
 
@@ -102,7 +111,7 @@ The scope passed in is expected to be a dict with keys
 - "component": the value to use for the "app.kubernetes.io/component" label
 */}}
 {{- define "hono.metadata" -}}
-name: {{ printf "%s-%s" .dot.Release.Name .name | quote }}
+name: {{ printf "%s-%s" (include "hono.fullname" .dot ) .name | quote }}
 namespace: {{ .dot.Release.Namespace | quote }}
 labels:
   app.kubernetes.io/name: {{ include "hono.name" .dot | quote }}
@@ -237,7 +246,7 @@ messaging:
 {{- if .dot.Values.amqpMessagingNetworkExample.enabled }}
   name: {{ printf "Hono %s" .component | quote }}
   amqpHostname: "hono-internal"
-  host: {{ printf "%s-dispatch-router" .dot.Release.Name | quote }}
+  host: {{ printf "%s-dispatch-router" ( include "hono.fullname" .dot ) | quote }}
   port: 5673
   keyPath: {{ .dot.Values.adapters.amqpMessagingNetworkSpec.keyPath | quote }}
   certPath: {{ .dot.Values.adapters.amqpMessagingNetworkSpec.certPath | quote }}
@@ -263,7 +272,9 @@ The scope passed in is expected to be a dict with keys
 kafka:
 {{- if .dot.Values.kafkaMessagingClusterExample.enabled }}
   commonClientConfig:
-    {{- $bootstrapServers := printf "%[1]s-%[2]s-0.%[1]s-%[2]s-headless:%d" .dot.Release.Name .dot.Values.kafka.nameOverride ( .dot.Values.kafka.service.ports.client | int ) }}
+    {{- $kafkaNameValues := pick .dot.Values.kafka "nameOverride" "fullnameOverride" }}
+    {{- $kafkaChartDotScope := dict "Release" .dot.Release "Chart" (dict "Name" "kafka") "Values" $kafkaNameValues }}
+    {{- $bootstrapServers := printf "%[1]s-0.%[1]s-headless:%d" ( include "hono.fullname" $kafkaChartDotScope ) ( .dot.Values.kafka.service.ports.client | int ) }}
     bootstrap.servers: {{ $bootstrapServers | quote }}
   {{- if eq .dot.Values.kafka.auth.clientProtocol "sasl_tls" }}
     security.protocol: "SASL_SSL"
@@ -321,7 +332,7 @@ The scope passed in is expected to be a dict with keys
 */}}
 {{- define "hono.deviceRegistryExampleClientConfig" -}}
 name: {{ printf "Hono %s" .component | quote }}
-host: {{ printf "%s-service-device-registry" .dot.Release.Name | quote }}
+host: {{ printf "%s-service-device-registry" ( include "hono.fullname" .dot ) | quote }}
 port: 5671
 credentialsPath: "/opt/hono/config/adapter.credentials"
 trustStorePath: {{ .dot.Values.deviceRegistryExample.clientTrustStorePath | default "/opt/hono/tls/ca.crt" | quote }}
@@ -343,7 +354,7 @@ command:
 {{- if .dot.Values.amqpMessagingNetworkExample.enabled }}
   name: {{ printf "Hono %s" $adapter | quote }}
   amqpHostname: "hono-internal"
-  host: {{ printf "%s-dispatch-router" .dot.Release.Name | quote }}
+  host: {{ printf "%s-dispatch-router" ( include "hono.fullname" .dot ) | quote }}
   port: 5673
   keyPath: {{ .dot.Values.adapters.commandAndControlSpec.keyPath | quote }}
   certPath: {{ .dot.Values.adapters.commandAndControlSpec.certPath | quote }}
@@ -384,7 +395,7 @@ commandRouter:
   {{- .dot.Values.adapters.commandRouterSpec | toYaml | nindent 2 }}
 {{- else }}
   name: {{ printf "Hono %s" $adapter | quote }}
-  host: {{ printf "%s-service-command-router" .dot.Release.Name | quote }}
+  host: {{ printf "%s-service-command-router" ( include "hono.fullname" .dot ) | quote }}
   port: 5671
   credentialsPath: "/opt/hono/config/adapter.credentials"
   trustStorePath: {{ .dot.Values.commandRouterService.clientTrustStorePath | default "/opt/hono/tls/ca.crt" | quote }}
@@ -461,7 +472,7 @@ quarkus:
       exporter:
         otlp:
           {{- if .dot.Values.jaegerBackendExample.enabled }}
-          endpoint: {{ printf "http://%s-jaeger-collector:4317" .dot.Release.Name | quote }}
+          endpoint: {{ printf "http://%s-jaeger-collector:4317" ( include "hono.fullname" .dot ) | quote }}
           {{- else }}
           endpoint: "http://127.0.0.1:4317"
           {{- end }}
@@ -532,7 +543,7 @@ The scope passed in is expected to be a dict with keys
 {{- $component := .componentConfig -}}
 {{- $probes := mergeOverwrite ( $global.probes | deepCopy ) ( $component.probes | default dict | deepCopy ) -}}
 {{- $deprecatedLivenessProbeInitialDelaySeconds := default .dot.Values.livenessProbeInitialDelaySeconds .componentConfig.livenessProbeInitialDelaySeconds -}}
-{{- $deprecatedReadinessProbeInitialDelaySeconds := default .dot.Values.readinessProbeInitialDelaySeconds .componentConfig.readinessProbeInitialDelaySeconds -}} 
+{{- $deprecatedReadinessProbeInitialDelaySeconds := default .dot.Values.readinessProbeInitialDelaySeconds .componentConfig.readinessProbeInitialDelaySeconds -}}
 livenessProbe:
   httpGet:
     path: {{ $probes.livenessProbe.httpGet.path }}
@@ -610,22 +621,22 @@ The scope passed in is expected to be a dict with keys
 {{- if ( ne $keySecretName "none" ) }}
 - name: "tls-keys"
   secret:
-    secretName: {{ ternary ( printf "%s-%s-example-keys" .dot.Release.Name .name ) $keySecretName ( eq $keySecretName "example" ) | quote }}
+    secretName: {{ ternary ( printf "%s-%s-example-keys" ( include "hono.fullname" .dot ) .name ) $keySecretName ( eq $keySecretName "example" ) | quote }}
 {{- end }}
 {{- $trustStoreConfigMapName := ( default "none" .componentConfig.tlsTrustStoreConfigMap | toString ) }}
 {{- if ( ne $trustStoreConfigMapName "none" ) }}
 - name: "tls-trust-store"
   configMap:
-    name: {{ ternary ( printf "%s-example-trust-store" .dot.Release.Name ) $trustStoreConfigMapName ( eq $trustStoreConfigMapName "example" ) | quote }}
+    name: {{ ternary ( printf "%s-example-trust-store" ( include "hono.fullname" .dot )) $trustStoreConfigMapName ( eq $trustStoreConfigMapName "example" ) | quote }}
 {{- end }}
 - name: "default-logging-config"
   configMap:
-    name: {{ printf "%s-default-logging-config" .dot.Release.Name | quote }}
+    name: {{ printf "%s-default-logging-config" ( include "hono.fullname" .dot ) | quote }}
     optional: true
 {{- $volumeName := printf "%s-conf" .name }}
 - name: {{ $volumeName | quote }}
   secret:
-    secretName: {{ printf "%s-%s" .dot.Release.Name $volumeName | quote }}
+    secretName: {{ printf "%s-%s" ( include "hono.fullname" .dot ) $volumeName | quote }}
 {{- if and .dot.Values.otelCollectorAgentConfigMap ( not .dot.Values.jaegerBackendExample.enabled ) }}
 - name: "otel-collector-config"
   configMap:

charts/hono/templates/dispatch-router/dispatch-router-route.yaml

@@ -24,5 +24,5 @@ spec:
     termination: passthrough
   to:
     kind: Service
-    name: {{ .Release.Name }}-dispatch-router-ext
+    name: {{ printf "%s-dispatch-router-ext" ( include "hono.fullname" . ) }}
 {{- end }}

charts/hono/templates/example-data-grid/statefulset.yaml

@@ -18,7 +18,7 @@ metadata:
   {{- include "hono.metadata" $args | nindent 2 }}
 spec:
   replicas: 1
-  serviceName: {{ printf "%s-%s" .Release.Name $args.name }}
+  serviceName: {{ printf "%s-%s" (include "hono.fullname" .) $args.name }}
   selector:
     matchLabels:
       {{- include "hono.matchLabels" $args | nindent 6 }}
@@ -43,7 +43,7 @@ spec:
         - name: JDK_JAVA_OPTIONS
           value: "-XX:MinRAMPercentage=85 -XX:MaxRAMPercentage=85"
         - name: JAVA_OPTIONS
-          value: {{ printf "-Djgroups.dns.query=%s-%s" .Release.Name $args.name }}
+          value: {{ printf "-Djgroups.dns.query=%s-%s" (include "hono.fullname" .) $args.name }}
         ports:
         - name: hotrod
           containerPort: 11222
@@ -74,5 +74,5 @@ spec:
       volumes:
       - name: conf
         configMap:
-          name: {{ printf "%s-%s-conf" .Release.Name $args.name }}
+          name: {{ printf "%s-%s-conf" (include "hono.fullname" .) $args.name }}
 {{- end }}

charts/hono/templates/hono-adapter-amqp/hono-adapter-amqp-route.yaml

@@ -21,5 +21,5 @@ spec:
     targetPort: amqp
   to:
     kind: Service
-    name: {{ .Release.Name }}-adapter-amqp
+    name: {{ printf "%s-adapter-amqp" ( include "hono.fullname" . ) }}
 {{- end }}

charts/hono/templates/hono-adapter-amqp/hono-adapter-amqp-sec-route.yaml

@@ -23,5 +23,5 @@ spec:
     termination: passthrough
   to:
     kind: Service
-    name: {{ .Release.Name }}-adapter-amqp
+    name: {{ printf "%s-adapter-amqp" ( include "hono.fullname" . ) }}
 {{- end }}

charts/hono/templates/hono-adapter-http/hono-adapter-http-route.yaml

@@ -21,5 +21,5 @@ spec:
     targetPort: http
   to:
     kind: Service
-    name: {{ .Release.Name }}-adapter-http
+    name: {{ printf "%s-adapter-http" ( include "hono.fullname" . ) }}
 {{- end }}

charts/hono/templates/hono-adapter-http/hono-adapter-http-sec-route.yaml

@@ -23,5 +23,5 @@ spec:
     termination: passthrough
   to:
     kind: Service
-    name: {{ .Release.Name }}-adapter-http
+    name: {{ printf "%s-adapter-http" ( include "hono.fullname" . ) }}
 {{- end }}

charts/hono/templates/hono-adapter-lora/hono-adapter-lora-route.yaml

@@ -21,5 +21,5 @@ spec:
     targetPort: http
   to:
     kind: Service
-    name: {{ .Release.Name }}-adapter-lora
+    name: {{ printf "%s-adapter-lora" ( include "hono.fullname" . ) }}
 {{- end }}

charts/hono/templates/hono-adapter-lora/hono-adapter-lora-sec-route.yaml

@@ -23,5 +23,5 @@ spec:
     termination: passthrough
   to:
     kind: Service
-    name: {{ .Release.Name }}-adapter-lora
+    name: {{ printf "%s-adapter-lora" ( include "hono.fullname" . ) }}
 {{- end }}

charts/hono/templates/hono-adapter-mqtt/hono-adapter-mqtt-route.yaml

@@ -21,5 +21,5 @@ spec:
     targetPort: mqtt
   to:
     kind: Service
-    name: {{ .Release.Name }}-adapter-mqtt
+    name: {{ printf "%s-adapter-mqtt" ( include "hono.fullname" . ) }}
 {{- end }}

charts/hono/templates/hono-adapter-mqtt/hono-adapter-mqtt-sec-route.yaml

@@ -23,5 +23,5 @@ spec:
     termination: passthrough
   to:
     kind: Service
-    name: {{ .Release.Name }}-adapter-mqtt
+    name: {{ printf "%s-adapter-mqtt" ( include "hono.fullname" . ) }}
 {{- end }}

charts/hono/templates/hono-service-auth/hono-service-auth-route.yaml

@@ -23,5 +23,5 @@ spec:
     termination: passthrough
   to:
     kind: Service
-    name: {{ .Release.Name }}-service-auth
+    name: {{ printf "%s-service-auth" ( include "hono.fullname" . ) }}
 {{- end }}