Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hawkbit: Use networking.k8s.io/v1 for Ingress if available #314

Closed
wants to merge 1 commit into from

Conversation

PSanetra
Copy link
Contributor

@PSanetra PSanetra commented Nov 8, 2021

This PR adds support for the v1 Ingress resource which is necessary for a deployment to Kubernetes 1.22.

@ctron
Copy link
Contributor

ctron commented Nov 9, 2021

@laverman @kaizimmerm could any of you take a look at this

@zidex
Copy link

zidex commented Jul 20, 2023

helm-chart is not supported anymore?

@bulmust
Copy link

bulmust commented May 30, 2024

@rondegroot
Copy link

I'm also waiting for this. Please merge this PR to keep supporting the helm-chart.

@bulmust
Copy link

bulmust commented Jul 16, 2024

I'm also waiting for this. Please merge this PR to keep supporting the helm-chart.

I give up and maintain it by myself.

By the way, you can add storage class under this line: storageClassName: {{ .Values.fileStorage.storageClass }} (Be careful to indent)

@paltaa
Copy link

paltaa commented Aug 9, 2024

Is this maintained? @bulmust do you have your own version public? Need to add custom serviceAccounts

@bulmust
Copy link

bulmust commented Aug 12, 2024

Is this maintained? @bulmust do you have your own version public? Need to add custom serviceAccounts

I do not publish my own helm chart to anywhere. By the way, this helm chart has a lot of problems like absence of serviceAccounts, storageClass etc, so as I understand this repo does not maintained anymore. You should also consider hawkbit microservice mode which is not compatible with this helm chart.

@paltaa
Copy link

paltaa commented Aug 12, 2024

Alright, thanks for the response! @bulmust, will just copy it and create our own version

@calohmn
Copy link
Contributor

calohmn commented Sep 29, 2024

Sorry this didn't get attention for so long. @strailov @avgustinmm Any comments on this? It looks good to me.
I guess it could make sense to merge this before the hawkbit 0.5.0 update PR.

@PSanetra In order to be able to merge this, the chart (patch) version needs to be updated in the Chart.yaml. This requires a prior git rebase, so that the change is based on the current chart version.
Could you do that still? Or, if you don't mind, I could make that change and push to your PR branch (if that was enabled on PR creation).

calohmn added a commit that referenced this pull request Oct 2, 2024
Apply change from PR #314: Hawkbit: Use networking.k8s.io/v1 for Ingress if available
@calohmn
Copy link
Contributor

calohmn commented Oct 2, 2024

Commit merged via #550, available in chart version 1.6.1.

@calohmn calohmn closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants