Skip to content

Commit

Permalink
Small fixes
Browse files Browse the repository at this point in the history
* Use appropriate protocol for registering default tenant

The device registry only exposes the management API via http if
the insecure endpoint is being enabled explicitly. Otherwise,
https needs to be used for registering default data with the
device registry.
  • Loading branch information
sophokles73 committed Oct 19, 2023
1 parent 24a32ea commit 6cf96a9
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions charts/hono/example/add_example_data_device_registry.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
#
# SPDX-License-Identifier: EPL-2.0
#*******************************************************************************
HTTP_BASE_URL="http://{{ include "hono.fullname" . }}-service-device-registry:8080/v1"
URL_SCHEME="{{- if ( eq .Values.deviceRegistryExample.hono.registry.http.insecurePortEnabled true ) }}http{{ else }}https{{ end }}"
URL_PORT=$([ "${URL_SCHEME}" = "http" ] && echo "8080" || echo "8443")
HTTP_BASE_URL="${URL_SCHEME}://{{ include "hono.fullname" . }}-service-device-registry:${URL_PORT}/v1"

check_status() {
EXIT_STATUS=$1
Expand All @@ -35,7 +37,7 @@ add_tenant(){
HTTP_REQUEST_BODY=$2

echo "Adding tenant [$TENANT_ID]"
HTTP_RESPONSE=$(curl -o /dev/null -sw "%{http_code}" \
HTTP_RESPONSE=$(curl -o /dev/null -sw "%{http_code}" -k \
-X POST "$HTTP_BASE_URL/tenants/$TENANT_ID" \
--header 'Content-Type: application/json' \
--data-raw "$HTTP_REQUEST_BODY")
Expand All @@ -49,7 +51,7 @@ register_device(){
HTTP_REQUEST_BODY=$3

echo "Registering device [$TENANT_ID:$DEVICE_ID]"
HTTP_RESPONSE=$(curl -o /dev/null -sw "%{http_code}" \
HTTP_RESPONSE=$(curl -o /dev/null -sw "%{http_code}" -k \
-X POST "$HTTP_BASE_URL/devices/$TENANT_ID/$DEVICE_ID" \
--header 'Content-Type: application/json' \
--data-raw "$HTTP_REQUEST_BODY")
Expand All @@ -64,7 +66,7 @@ add_credentials(){
HTTP_REQUEST_BODY=$3

echo "Adding credentials [$TENANT_ID:$DEVICE_ID]"
HTTP_RESPONSE=$(curl -o /dev/null -sw "%{http_code}" \
HTTP_RESPONSE=$(curl -o /dev/null -sw "%{http_code}" -k \
-X PUT "$HTTP_BASE_URL/credentials/$TENANT_ID/$DEVICE_ID" \
--header 'Content-Type: application/json' \
--data-raw "$HTTP_REQUEST_BODY")
Expand Down

0 comments on commit 6cf96a9

Please sign in to comment.