Add WebSockets OnMessage Parameter Validation Diagnostic #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAvi123
changed the title
TheAvi123
changed the title
giancarlopernudisegura
suggested changes
Apr 15, 2022
Comment on lines
+86
to
+94
| /* For OnMessage annotation */ | ||
| public static final Set<String> ON_MESSAGE_PARAM_OPT_TYPES = new HashSet<>(Arrays.asList("jakarta.websocket.Session")); | ||
| public static final Set<String> RAW_ON_MESSAGE_PARAM_OPT_TYPES = new HashSet<>(Arrays.asList("Session")); | ||
| /* For OnMessage (Text) annotation */ | ||
| public static final Set<String> ON_MESSAGE_TEXT_TYPES = new HashSet<>(Arrays.asList("java.lang.String", "java.io.Reader", "String", "Reader")); | ||
| /* For OnMessage (Text) annotation */ | ||
| public static final Set<String> ON_MESSAGE_BINARY_TYPES = new HashSet<>(Arrays.asList("java.nio.ByteBuffer", "java.io.InputStream", "ByteBuffer", "InputStream")); | ||
| /* For OnMessage (Text) annotation */ | ||
| public static final Set<String> ON_MESSAGE_PONG_TYPES = new HashSet<>(Arrays.asList("jakarta.websocket.PongMessage", "PongMessage")); |
There was a problem hiding this comment.
If you pull the latest from main, I suspect that you'll be able to use the already defined strings for these types.
| @@ -1,5 +1,5 @@ | |||
| package io.openliberty.sample.jakarta.websocket; | |||
|
|
|||
There was a problem hiding this comment.
seems like you accidentally added whitespace here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #244