Add keyexpr_was_declared api function #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -77,6 +77,14 @@ | |||
| } | |||
| } | |||
|
|
|||
| _Bool zp_keyexpr_was_declared(const z_keyexpr_t *keyexpr) { | |||
Check warning
Code scanning / Cppcheck (reported by Codacy)
misra violation 804 with no text in the supplied rule-texts-file Warning
|
LGTM but I'd like to have the review as well from @milyin . |
milyin
requested changes
Jan 10, 2024
| @@ -97,6 +97,18 @@ z_owned_str_t z_keyexpr_to_string(z_keyexpr_t keyexpr); | |||
| */ | |||
| z_bytes_t z_keyexpr_as_bytes(z_keyexpr_t keyexpr); | |||
|
|
|||
| /** | |||
| * Indicates if the key expression has been declared but don't guarantee it's still in session. | |||
There was a problem hiding this comment.
I would add that it's not possible to get key expression string representation if it's declared and add a reference to zp_resolve as a way to access this data. This will make clear why this function is needed and connect this function to two functions above
jean-roland
force-pushed
the
ft_keyexpr
branch
from
57807b2 to
f32cccd
Compare
milyin
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #242