-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'using namespace std' statement. Fixes #276 #281
Conversation
LGTM but I'd really like a review from @milyin |
I forgot to mention that the compilation as backend for zenoh-c also passes. |
@cguimaraes this fix still doesn't work beacuse it leaks out defines #define atomic_store_explicit std::atomic_store_explicit
#define atomic_fetch_add_explicit std::atomic_fetch_add_explicit
#define atomic_fetch_sub_explicit std::atomic_fetch_sub_explicit
#define memory_order_acquire std::memory_order_acquire
#define memory_order_release std::memory_order_release
#define memory_order_relaxed std::memory_order_relaxed so the following code fails to compile with zenoh-pico: std::memory_order order = std::memory_order_relaxed; with error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the defines with names same as functions of std library still leaks to global namespace
Looks good now, thank you! |
Fixes #276