Skip to content

Commit

Permalink
fix: infinite wait in build-check workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
jean-roland committed Oct 31, 2023
1 parent a0e3696 commit d2118bc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,20 @@ jobs:

- name: Run docker image
run: docker run --name zenoh_router --init --net host -d eclipse/zenoh:master
continue-on-error: true

- name: Build project
run: |
make all
python3 ./build/tests/modularity.py --pub $Z_FEATURE_PUBLICATION --sub $Z_FEATURE_SUBSCRIPTION --queryable $Z_FEATURE_QUERYABLE --query $Z_FEATURE_QUERY
continue-on-error: true
timeout-minutes: 5
env:
Z_FEATURE_PUBLICATION: ${{ matrix.feature_publication }}
Z_FEATURE_SUBSCRIPTION: ${{ matrix.feature_subscription }}
Z_FEATURE_QUERYABLE: ${{ matrix.feature_queryable }}
Z_FEATURE_QUERY: ${{ matrix.feature_query }}

- name: Stop docker image
if: always()
run: |
docker stop zenoh_router
docker rm zenoh_router
1 change: 1 addition & 0 deletions tests/modularity.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ def pub_and_sub(args):
# Send "q" command to z_sub to stop it
z_sub_process.stdin.write("q\n")
z_sub_process.stdin.flush()
time.sleep(1)

# Wait for z_sub to finish
z_sub_process.wait()
Expand Down

0 comments on commit d2118bc

Please sign in to comment.