Add zenoh-c-prebuilt Conan recipe #334
Conversation
oteffahi
force-pushed
the
conan/recipe-prebuilt
branch
from
c3cbe76 to
300e68f
Compare
oteffahi
force-pushed
the
conan/recipe-prebuilt
branch
from
300e68f to
0768a64
Compare
There was a problem hiding this comment.
Aside from the one issue noted on the test package, this worked for me. I was able to build another conan package (up-zenoh-client-cpp) using zenohc/0.10.1-rc as a dependency.
| test_type = "explicit" | ||
|
|
||
| def requirements(self): | ||
| self.tool_requires("cmake/[>=3.16 <4]") | ||
| self.requires(self.tested_reference_str) |
There was a problem hiding this comment.
I'm not entirely sure why, but with conan 1.63 this didn't work for me. I had to move the tool_requires statement out of requirements(). The documentation indicates that either one should work.
| test_type = "explicit" | |
| def requirements(self): | |
| self.tool_requires("cmake/[>=3.16 <4]") | |
| self.requires(self.tested_reference_str) | |
| test_type = "explicit" | |
| tool_requires = "cmake/[>=3.16 <4]" | |
| def requirements(self): | |
| self.requires(self.tested_reference_str) |
It is entirely possible this is just something I was doing wrong.
There was a problem hiding this comment.
@gregmedd Thank you for testing it on 1.63, as I personally only tested with conan v2. I will look into this issue as soon as possible.
There was a problem hiding this comment.
@gregmedd The issue was happening because the tool_requires was being called in requirements instead of build_requirements. Conan2 does not raise an error in this case, but older versions do. Fixed in Move tool_requires to build_requirements function.
| "Linux": | ||
| "x86_64": | ||
| url: "https://github.com/eclipse-zenoh/zenoh-c/releases/download/0.10.1-rc/zenoh-c-0.10.1-rc-x86_64-unknown-linux-gnu.zip" | ||
| sha256: "0554b0fe753df3c023b09e005b309d654b1cc33ddc34190b5a5c370b72281c3b" |
There was a problem hiding this comment.
I've been thinking on this for a few days to figure out how to deal with tagged releases and Conan packages on a few of the uProtocol libraries I'm working on, and have a question:
What is the workflow for making a tagged release? It looks like a tag would first need to be added and all of the binaries built / published. Then a follow-up commit after the tagged commit would update the recipes so the Conan packages can be built from the new release. Is that correct?
That would mean that the tagged commit is not actually 100% the release because the recipes are wrong. But the tag can't be moved after the recipes are updated (maybe only in the build from source case?) without changing some of the hashes.
I'm sure I'm just missing a step somewhere 😅
There was a problem hiding this comment.
You are right, there is a bootstrap-like problem. It's something we have discussed internally and so far moving the tag and updating the hashes seems to be the way to go. This will be done as part of the release process.
This PR add a Conan recipe to install Zenoh-C (Currently only
0.10.1-rc) without requiring Rust on the target host.The recipe pulls the necessary artefacts from upstream's github release for the requested version.
This recipe only supports targets for which Zenoh-C is compiled in its releases.
Library artefacts for all targets are dynamically linked.