Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect handling of empty host portion of the host header #4885

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

vietj
Copy link
Member

@vietj vietj commented Oct 6, 2023

Fix a regression with the introduction of HTTP authority handling with HTTP/1.1 in which the server fails when handling an empty host portion of the host header. The authority method can also return null when no host header is present for HTTP/1.x

@vietj vietj added this to the 5.0.0 milestone Oct 6, 2023
@vietj vietj self-assigned this Oct 6, 2023
…h HTTP/1.1 in which the server fails when handling an empty host portion of the host header. The authority method can also return null when no host header is present for HTTP/1.x
@vietj vietj force-pushed the allow-empty-host-portion-of-host-header branch from 0e8dd57 to 7d9ed0f Compare October 6, 2023 08:47
@vietj vietj merged commit 3230e4d into master Oct 6, 2023
6 checks passed
@vietj vietj deleted the allow-empty-host-portion-of-host-header branch October 6, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant